From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7623 invoked by alias); 25 Jan 2011 08:46:54 -0000 Received: (qmail 7614 invoked by uid 22791); 25 Jan 2011 08:46:53 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mms1.broadcom.com (HELO mms1.broadcom.com) (216.31.210.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Jan 2011 08:46:49 +0000 Received: from [10.9.200.131] by mms1.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.3.2)); Tue, 25 Jan 2011 00:48:07 -0800 X-Server-Uuid: 02CED230-5797-4B57-9875-D5D2FEE4708A Received: from mail-irva-13.broadcom.com (10.11.16.103) by IRVEXCHHUB01.corp.ad.broadcom.com (10.9.200.131) with Microsoft SMTP Server id 8.2.247.2; Tue, 25 Jan 2011 00:46:34 -0800 Received: from [10.177.69.119] (unknown [10.177.69.119]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id B0CC074D04 for ; Tue, 25 Jan 2011 00:46:33 -0800 (PST) Message-ID: <4D3E8DE8.6000303@broadcom.com> Date: Tue, 25 Jan 2011 08:51:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.13) Gecko/20101207 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: deprecated_throw_reason? (was Re: New ARI warning Tue Jan 25 01:55:01 UTC 2011) References: <20110125015501.GA4054@sourceware.org> <20110124221053.1f12ee32@mesquite.lan> In-Reply-To: <20110124221053.1f12ee32@mesquite.lan> Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00485.txt.bz2 On 25/01/2011 05:10, Kevin Buettner wrote: > On Tue, 25 Jan 2011 01:55:01 +0000 > GDB Administrator wrote: > >>> gdb/remote-mips.c:513: deprecated: deprecated throw_reason: Do not use deprecated throw_reason, see declaration for details >> gdb/remote-mips.c:513: deprecated_throw_reason (RETURN_ERROR); > [...] >>> gdb/remote-mips.c:2285: deprecated: deprecated throw_reason: Do not use deprecated throw_reason, see declaration for details >> gdb/remote-mips.c:2285: deprecated_throw_reason (RETURN_QUIT); > > Does anyone know how these uses of deprecated_throw_reason should > be fixed? > > I've looked at the comment before the declaration of > deprecated_throw_reason(). It reads as follows: > > /* Instead of deprecated_throw_reason, code should use catch_exception > and throw_exception. */ > extern void deprecated_throw_reason (enum return_reason reason) > ATTRIBUTE_NORETURN; > > This sort of makes sense, except that the code in question just > wants to do a throw. I suppose I could try to inline the relevant > bits from the definition of deprecated_throw_reason(), but that > seems ugly. I think in these cases switching to throw_error (mips_error) or throw_vfatal (mips_kill) might be a better choice. The text that is currently printed unconditionally in mips_error could become the message for throw_error and GENERIC_ERROR the error type. Andrew