From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10247 invoked by alias); 19 Jan 2011 21:39:45 -0000 Received: (qmail 10238 invoked by uid 22791); 19 Jan 2011 21:39:45 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 Jan 2011 21:39:40 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id C963F45006; Wed, 19 Jan 2011 13:39:33 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id BA184CD944; Wed, 19 Jan 2011 13:39:33 -0800 (PST) Message-ID: <4D375A14.8030504@vmware.com> Date: Wed, 19 Jan 2011 21:50:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Paul Koning CC: Kevin Buettner , "gdb-patches@sourceware.org" Subject: Re: [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o References: <20110119141436.2d8422fe@mesquite.lan> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00416.txt.bz2 It won't hurt anything, but it probably won't be used. AFAIK, that file is just for monitor debugging on a bare-metal eval board. Paul Koning wrote: > Shouldn't that just be for the MIPS based targets (if there still are any left) that use this protocol? > > A lot of them probably just use the standard GDB remote protocol (I know ours does -- NetBSD based). > > paul > > On Jan 19, 2011, at 4:14 PM, Kevin Buettner wrote: > >> I spent some time last year fixing bitrot in remote-mips.c, but >> forgot to update configure.tgt so that it's actually used by mips >> targets. >> >> Any objections to the patch below? >> >> Kevin >> >> * configure.tgt (mips*-*-*): Add remote-mips.o to gdb_target_obs. >> >> Index: configure.tgt >> =================================================================== >> RCS file: /cvs/src/src/gdb/configure.tgt,v >> retrieving revision 1.241 >> diff -u -p -r1.241 configure.tgt >> --- configure.tgt 14 Jan 2011 18:16:34 -0000 1.241 >> +++ configure.tgt 19 Jan 2011 20:51:20 -0000 >> @@ -373,7 +373,7 @@ mips64*-*-openbsd*) >> ;; >> mips*-*-*) >> # Target: MIPS >> - gdb_target_obs="mips-tdep.o" >> + gdb_target_obs="mips-tdep.o remote-mips.o" >> gdb_sim=../sim/mips/libsim.a >> ;; >> >> >