From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19512 invoked by alias); 13 Jan 2011 16:44:51 -0000 Received: (qmail 19329 invoked by uid 22791); 13 Jan 2011 16:44:48 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Jan 2011 16:44:43 +0000 Received: (qmail 31445 invoked from network); 13 Jan 2011 16:44:41 -0000 Received: from unknown (HELO ?10.155.3.22?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 13 Jan 2011 16:44:41 -0000 Message-ID: <4D2F2BF9.8010103@codesourcery.com> Date: Thu, 13 Jan 2011 16:47:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 MIME-Version: 1.0 To: Ulrich Weigand CC: gdb-patches@sourceware.org Subject: Re: [patch, arm] Consistent display of registers in corefile References: <201101131555.p0DFtdIs002421@d06av02.portsmouth.uk.ibm.com> In-Reply-To: <201101131555.p0DFtdIs002421@d06av02.portsmouth.uk.ibm.com> Content-Type: multipart/mixed; boundary="------------090803060308080603090708" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00301.txt.bz2 This is a multi-part message in MIME format. --------------090803060308080603090708 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 715 On 01/13/2011 09:55 AM, Ulrich Weigand wrote: > Yao Qi wrote: > >> FPS belongs to float_reggroup, save_reggroup, and restore_reggroup, >> instead of float_reggroup only. > >> + /* FPS register's type is INT, but belongs to float_reggroup, >> + save_regroup, and restore_reggroup. */ >> if (regnum == ARM_FPS_REGNUM) >> - return (group == float_reggroup); >> + return (group == float_reggroup >> + || group == save_reggroup >> + || group == restore_reggroup); >> else >> return default_register_reggroup_p (gdbarch, regnum, group); > > Well, FPS should also belong to all_reggroup, otherwise it wil not > show up in "info all-registers" ... OK, fix it in my new patch. -- Yao Qi --------------090803060308080603090708 Content-Type: text/x-patch; name="fps_save_restore_reggroup.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fps_save_restore_reggroup.patch" Content-length: 896 gdb/ * arm-tdep.c (arm_register_reggroup_p): FPS register is in save_reggroup, restore_reggroup and all_reggroup. diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 9ec410d..e24a6d9 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -7234,9 +7234,14 @@ static int arm_register_reggroup_p (struct gdbarch *gdbarch, int regnum, struct reggroup *group) { - /* FPS register's type is INT, but belongs to float_group. */ + /* FPS register's type is INT, but belongs to float_reggroup. Beside + this, FPS register belongs to save_regroup, restore_reggroup, and + all_reggroup, of course. */ if (regnum == ARM_FPS_REGNUM) - return (group == float_reggroup); + return (group == float_reggroup + || group == save_reggroup + || group == restore_reggroup + || group == all_reggroup); else return default_register_reggroup_p (gdbarch, regnum, group); } --------------090803060308080603090708--