From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7853 invoked by alias); 13 Jan 2011 16:13:53 -0000 Received: (qmail 7840 invoked by uid 22791); 13 Jan 2011 16:13:52 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Jan 2011 16:13:48 +0000 Received: (qmail 6629 invoked from network); 13 Jan 2011 16:13:46 -0000 Received: from unknown (HELO ?10.155.3.22?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 13 Jan 2011 16:13:46 -0000 Message-ID: <4D2F24B9.6050509@codesourcery.com> Date: Thu, 13 Jan 2011 16:34:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 MIME-Version: 1.0 To: Matthew Gretton-Dann CC: gdb-patches@sourceware.org Subject: Re: [try 3rd] arm_pc_is_thumb takes displaced stepping into account References: <4D0F0ABA.9010506@codesourcery.com> <201012200804.oBK84oPu005379@glazunov.sibelius.xs4all.nl> <4D0F5D36.2040909@codesourcery.com> <4D10D377.8080100@codesourcery.com> <20101223042236.GS2596@adacore.com> <4D12F3A8.3020102@codesourcery.com> <4D2D27F2.7050303@codesourcery.com> <1294931747.9907.137.camel@e102319-lin.cambridge.arm.com> In-Reply-To: <1294931747.9907.137.camel@e102319-lin.cambridge.arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00299.txt.bz2 On 01/13/2011 09:15 AM, Matthew Gretton-Dann wrote: > I agree with Ulrich, and prefer this latest patch to your previous ones > - but I am still not 100% happy with it, as I think it would be better > not to need anything from infrun.c at all here. Agree. The perfect situation is that we need nothing from infrun.c in tdep. > What could be done instead is to have the displaced stepping routines > maintain a list of the areas of memory that are being used as scratch > space, and the instruction set state of the instructions in those areas. > Then arm_pc_is_thumb should check this list to see if the PC falls into > one of these areas, and return the appropriate value. That sounds good. Again, thanks for your inputs. -- Yao Qi