From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19009 invoked by alias); 12 Jan 2011 22:05:24 -0000 Received: (qmail 18999 invoked by uid 22791); 12 Jan 2011 22:05:23 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Jan 2011 22:05:19 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 570BCA009; Wed, 12 Jan 2011 14:05:18 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id 4F73DC9CF9; Wed, 12 Jan 2011 14:05:18 -0800 (PST) Message-ID: <4D2E259D.2050000@vmware.com> Date: Wed, 12 Jan 2011 22:10:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Mark Kettenis CC: "gdb-patches@sourceware.org" , "brobecker@adacore.com" Subject: Re: [RFA] Evening up the right margins References: <4D2D1D4B.9070509@vmware.com> <201101122128.p0CLSE7q017580@glazunov.sibelius.xs4all.nl> In-Reply-To: <201101122128.p0CLSE7q017580@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00284.txt.bz2 Mark Kettenis wrote: >> Date: Tue, 11 Jan 2011 19:17:31 -0800 >> From: Michael Snyder >> >> Mark and Joel, I'm especially interested in your feedback. >> >> This patch is meant to help even up the right margins without adding >> extra lines to the file. If folks approve, I'll do more. > > The thought that comes to my mind is "if it ain't broke, don't fix > it". That is, of course, a time tested principal. However, I would argue that nasty-looking margins are a form of breakage. Not as severe as testsuite failures or crashes, but arguably worthy of fixing. > I think the benefit from these changes is marginal. No pun intended, I'm sure. ;-) > Is this > really worth the extra churn in the repository? It does make diffing > revisions of the affected files more difficult... I feel that it makes reading the code easier, which is the trade-off.