Re: New ARI warning Mon Jan 10 01:56:19 UTC 2011

[Michael Snyder <msnyder@vmware.com>]

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

GDB Administrator wrote:
> 596a597,600
>> gdb/m32r-rom.c:450: gettext: _ markup: All messages should be marked up with _.
> gdb/m32r-rom.c:450:	error ("Please use 'set board-address' to "
>> gdb/m32r-rom.c:482: gettext: _ markup: All messages should be marked up with _.
> gdb/m32r-rom.c:482:	error ("Need to know gdb host computer's "
>> gdb/m32r-rom.c:495: gettext: _ markup: All messages should be marked up with _.
> gdb/m32r-rom.c:495:	error ("Need to know default download "
>> gdb/m32r-rom.c:517: gettext: _ markup: All messages should be marked up with _.
> gdb/m32r-rom.c:517:    error ("Upload file not found: %s.srec\n"


Fixed up as below:



[-- Attachment #2: ari2.txt --]
[-- Type: text/plain, Size: 2091 bytes --]

2011-01-08  Michael Snyder  <msnyder@vmware.com>

	* m32r-rom.c (m32r_upload_command): Fix up ARI warnings for _
	markup.

Index: m32r-rom.c
===================================================================
RCS file: /cvs/src/src/gdb/m32r-rom.c,v
retrieving revision 1.44
diff -u -p -r1.44 m32r-rom.c
--- m32r-rom.c	9 Jan 2011 03:20:33 -0000	1.44
+++ m32r-rom.c	10 Jan 2011 02:41:25 -0000
@@ -447,8 +447,8 @@ m32r_upload_command (char *args, int fro
 	myIPaddress++;
 
       if (!strncmp (myIPaddress, "0.0.", 4))	/* empty */
-	error ("Please use 'set board-address' to "
-	       "set the M32R-EVA board's IP address.");
+	error (_("Please use 'set board-address' to "
+		 "set the M32R-EVA board's IP address."));
       if (strchr (myIPaddress, '('))
 	*(strchr (myIPaddress, '(')) = '\0';	/* delete trailing junk */
       board_addr = xstrdup (myIPaddress);
@@ -479,8 +479,8 @@ m32r_upload_command (char *args, int fro
 	    }
 	}
       if (server_addr == 0)	/* failed?  */
-	error ("Need to know gdb host computer's "
-	       "IP address (use 'set server-address')");
+	error (_("Need to know gdb host computer's "
+		 "IP address (use 'set server-address')"));
     }
 
   if (args == 0 || args[0] == 0)	/* No args: upload the current
@@ -492,8 +492,8 @@ m32r_upload_command (char *args, int fro
       if (current_directory)
 	download_path = xstrdup (current_directory);
       else
-	error ("Need to know default download "
-	       "path (use 'set download-path')");
+	error (_("Need to know default download "
+		 "path (use 'set download-path')"));
     }
 
   gettimeofday (&start_time, NULL);
@@ -514,9 +514,9 @@ m32r_upload_command (char *args, int fro
   resp_len = monitor_expect_prompt (buf, sizeof (buf));	/* parse result?  */
 
   if (buf[0] == 0 || strstr (buf, "complete") == 0)
-    error ("Upload file not found: %s.srec\n"
-	   "Check IP addresses and download path.",
-       args);
+    error (_("Upload file not found: %s.srec\n"
+	     "Check IP addresses and download path."),
+	   args);
   else
     printf_filtered (" -- Ethernet load complete.\n");