From: Yao Qi <yao@codesourcery.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: duplicated code in gdb and gdbserver
Date: Fri, 07 Jan 2011 15:23:00 -0000 [thread overview]
Message-ID: <4D272FF6.3070402@codesourcery.com> (raw)
I noticed that sharing code of GDB and GDBServer is discussed in 2010
GCC Summit.
http://sourceware.org/gdb/wiki/2010_GCC_Summit_BoF
Looks like one conclusion is that "it is likely to be quite complex". I
don't understand this point fully, so I had a try by myself to create a
new file linux-common.h in gdb/common/, move some duplicated macro
definitions from gdb/linux-nat.c and gdb/gdbserver/linux-low.c to
common/linux-common.h, and adjust *.h files include order. Then, both
GDB and GDBServer can be build on x86. Totally, it costs me nearly half
an hour to complete this experiment.
Could anyone tell me which part of this work is "quite complex"? Am I
missing something?
Regardless of this potential complexity I haven't met, it is worthwhile
moving obviously common/duplicated code into single file, isn't?
Comments are welcome.
--
Yao (é½å°§)
next reply other threads:[~2011-01-07 15:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 15:23 Yao Qi [this message]
2011-01-07 16:37 ` Doug Evans
2011-01-08 3:34 ` Yao Qi
2011-01-08 5:17 ` Joel Brobecker
2011-01-10 13:39 ` Frank Ch. Eigler
2011-01-10 14:09 ` Joel Brobecker
2011-01-10 15:10 ` Frank Ch. Eigler
2011-01-10 15:50 ` Paul Koning
2011-01-10 15:51 ` Doug Evans
2011-01-10 15:54 ` Frank Ch. Eigler
2011-01-10 16:35 ` Doug Evans
2011-01-10 19:02 ` Frank Ch. Eigler
2011-01-11 23:35 ` Joel Brobecker
2011-01-11 23:38 ` Joel Brobecker
2011-01-12 0:30 ` Frank Ch. Eigler
2011-01-12 17:54 ` Doug Evans
2011-01-12 18:06 ` Doug Evans
2011-01-12 18:43 ` Paul Koning
2011-01-12 19:04 ` Doug Evans
2011-01-12 20:09 ` Joel Brobecker
2011-01-12 20:48 ` Frank Ch. Eigler
2011-01-14 17:04 ` Doug Evans
2011-01-12 15:47 ` Tom Tromey
2011-01-07 17:17 ` Stan Shebs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D272FF6.3070402@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox