From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11381 invoked by alias); 5 Jan 2011 21:38:10 -0000 Received: (qmail 11371 invoked by uid 22791); 5 Jan 2011 21:38:10 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Jan 2011 21:38:05 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 49E0F13014; Wed, 5 Jan 2011 13:38:02 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 390BDCD933; Wed, 5 Jan 2011 13:38:02 -0800 (PST) Message-ID: <4D24E4B9.40500@vmware.com> Date: Wed, 05 Jan 2011 21:38:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Pierre Muller CC: "gdb-patches@sourceware.org" Subject: Re: [patch] Shorten lines of >= 80 columns. References: <4D237089.1080309@vmware.com> <000c01cbac44$48830210$d9890630$@muller@ics-cnrs.unistra.fr> <4D237C6A.9050609@vmware.com> <000001cbacb7$4fc38f40$ef4aadc0$@muller@ics-cnrs.unistra.fr> <4D24B777.4030403@vmware.com> In-Reply-To: <4D24B777.4030403@vmware.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00091.txt.bz2 Michael Snyder wrote: > Pierre Muller wrote: >>>> case LOC_CONST_BYTES: >>>> - internal_error (__FILE__, __LINE__, >>>> - _("gen_var_ref: LOC_CONST_BYTES symbols are not >>>> supported")); >>>> + internal_error (__FILE__, __LINE__, _("\ >>>> +gen_var_ref: LOC_CONST_BYTES symbols are not supported")); >>>> >>>> I think this kind of changes confuses cvs >>>> for the 'cvs diff -u -p': >>>> it might regard the new line >>>> +gen_var_ref: LOC_CONST_BYTES symbols are not supported")); >>>> as a new starting function line and >>>> report a wrong function name... >>>> Of course not really for your example here, >>>> as the start of the line is >>>> the name of the function itself... >>>> But I remember having seen >>>> wrong function name reported with 'cvs -u -p' >>>> due to the use of '_("\' >>>> construct which force starting next line without >>>> spaces... >>>> >>>> Pierre Muller >>>> GDB pascal language maintainer >>> Hmmm... well, we already have tons of similar constructs in the tree. >> Yes, I know, and it should of course not >> retard your commit. > > No, I'm concerned about it. If I can see a "nice" solution, I will > make changes. > >> I was just wondering if we could try to avoid >> those construct in the future, but I am not sure there is a >> simple solution... >> >> In general, I was wondering if we could use >> ,_( >> "gen_var_ref: LOC_CONST_BYTES symbols are not supported")); >> instead of >> ,_("\ >> gen_var_ref: LOC_CONST_BYTES symbols are not supported")); >> >> at least for case that are shorter than 80 - 5(2'"'+2')'+1';') chars? >> But this might be against GNU coding style. > > The trouble with that is that emacs will not indent it that way. Got it. I can split this up like this: internal_error (__FILE__, __LINE__, _("gen_var_ref: LOC_CONST_BYTES " "symbols are not supported")); Submission to follow after final regression test.