From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7581 invoked by alias); 29 Dec 2010 03:09:05 -0000 Received: (qmail 7569 invoked by uid 22791); 29 Dec 2010 03:09:03 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Dec 2010 03:08:57 +0000 Received: (qmail 15016 invoked from network); 29 Dec 2010 03:08:55 -0000 Received: from unknown (HELO ?192.168.0.101?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 29 Dec 2010 03:08:55 -0000 Message-ID: <4D1AA642.5040608@codesourcery.com> Date: Wed, 29 Dec 2010 05:48:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [patch 0/3] Displaced stepping for 16-bit Thumb instructions References: <4D15F9B8.5070705@codesourcery.com> In-Reply-To: <4D15F9B8.5070705@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00534.txt.bz2 On 12/25/2010 10:03 PM, Yao Qi wrote: > > Regression tested these three patches along with another pending patch > on armv7l-unknown-linux-gnueabi. As Pedro suggested, I run the whole test suite with displaced stepping enabled. (I force to enable displaced stepping by hacking infrun.c to set can_use_displaced_stepping to can_use_displaced_stepping_on. Any other methods to enable displaced stepping? I think 'make check RUNTESTFLAGS='"../gdb -ex "set displaced on""'' might work, but I didn't try.) Totally, we got three tests results (run with option -mthumb/-march=armv5t on an ARM board on which system library is compiled in ARM mode), they are base : GDB cvs trunk, thumb_disp : GDB cvs trunk with three patches applied, thumb_disp_on: GDB cvs trunk with three patches applied, and displaced stepping turned on Compared between thumb_disp and thumb_disp_on, test result is the same. Compared between base and thumb_disp, some failures in gdb.base/structs.exp are fixed, which is out of my expectation. There are three new failures came from `gdb_test_no_output "set displaced-stepping off"' FAIL: gdb.sum:gdb.arch/arm-disp-step.exp: set displaced-stepping off [#2] FAIL: gdb.sum:gdb.arch/arm-disp-step.exp: set displaced-stepping off [#3] FAIL: gdb.sum:gdb.arch/arm-disp-step.exp: set displaced-stepping off [#4] > +proc try_continue_with_displaced_step { msg loc } { > + gdb_test_no_output "set displaced-stepping on" > + gdb_test_multiple "continue" "continue to $msg" { > + -re ".*$loc.*" { > + pass "continue to $msg" > + } > + -re "Displaced stepping is only supported in.*" { > + gdb_test_no_output "set displaced-stepping off" Fix these failures by changing this line to `gdb_test "set displaced-stepping off" ""' Comments? -- Yao (齐尧)