From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23859 invoked by alias); 24 Dec 2010 09:36:38 -0000 Received: (qmail 23769 invoked by uid 22791); 24 Dec 2010 09:36:36 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Dec 2010 09:36:32 +0000 Received: (qmail 7962 invoked from network); 24 Dec 2010 09:36:30 -0000 Received: from unknown (HELO ?192.168.1.11?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 Dec 2010 09:36:30 -0000 Message-ID: <4D146992.3030200@codesourcery.com> Date: Sat, 25 Dec 2010 14:03:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [patch i386, 0/2] skip insns generated by -fstack-protector References: <4D145811.4060805@codesourcery.com> <4D145B02.8030507@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00457.txt.bz2 On 12/24/2010 05:15 PM, Andreas Schwab wrote: >> + The change of ESP caused by this instruction is computed a little bit >> > + different here, because we can't get value of offset from >> > + instruction itself. We simulate the execution of this in struction > s/in struction/instruction/ Oops. I'll fix it along with other reviewers' comments together. -- Yao Qi