From: Raphael Zulliger <zulliger@indel.ch>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: proposal: substitute-path handles foreign dir separators
Date: Mon, 20 Dec 2010 06:38:00 -0000 [thread overview]
Message-ID: <4D0EF9CE.80402@indel.ch> (raw)
In-Reply-To: <834oach14b.fsf@gnu.org>
On 17.12.2010 16:26, Eli Zaretskii wrote:
> There were discussions on this a few months ago, you may wish to look
> them up.
I just tried to look it up but I couldn't find the particular discussion
unless you refer to the one mentioned by Pedor Alves:
<http://sourceware.org/ml/gdb-patches/2010-04/msg00759.html>
> This isn't the right way, for 2 reasons:
>
> . It makes the code uglier than it must be.
>
> . The support for DOS-style file names is based on compile-time
> macros, so it cannot be turned on and off. Thus, you leave no fire
> escape for Unix users who just happen to have file names with
> literal backslashes, improbable as that may be.
I agree with both. I didn't thought about the case of using escaped file
names on Unix systems.
> In this part, I simply don't understand why you needed the
> HAVE_DOS_BASED_FILE_SYSTEM branch. DOS/Windows file-system calls
> support forward slashes just fine, so there's no need to rewrite the
> slashes.
Thanks. Somehow I wasn't aware of that.
> Finally, please wait for other opinions, as I'm not sure mine is in
> consensus.
>
I think we should forget about my patch as I posted it. Let's continue
the discussion based on Pedros patch instead.
Thanks.
Raphael
prev parent reply other threads:[~2010-12-20 6:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 14:18 Raphael Zulliger
2010-12-17 15:26 ` Eli Zaretskii
2010-12-17 17:50 ` Pedro Alves
2010-12-17 19:23 ` Eli Zaretskii
2010-12-17 19:44 ` Pedro Alves
2010-12-17 20:11 ` Pedro Alves
2010-12-20 7:41 ` Raphael Zulliger
2010-12-22 12:00 ` Pedro Alves
2010-12-20 6:38 ` Raphael Zulliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0EF9CE.80402@indel.ch \
--to=zulliger@indel.ch \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox