From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4604 invoked by alias); 15 Dec 2010 13:17:57 -0000 Received: (qmail 4578 invoked by uid 22791); 15 Dec 2010 13:17:56 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Dec 2010 13:17:51 +0000 Received: (qmail 22114 invoked from network); 15 Dec 2010 13:17:49 -0000 Received: from unknown (HELO ?192.168.0.104?) (ams@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Dec 2010 13:17:49 -0000 Message-ID: <4D08BFFA.3010401@codesourcery.com> Date: Wed, 15 Dec 2010 13:17:00 -0000 From: Andrew Stubbs User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: Mike Frysinger CC: Daniel Jacobowitz , toolchain-devel@blackfin.uclinux.org, gdb-patches@sourceware.org, Pedro Alves Subject: Re: [toolchain-devel] [PATCH v2] gdbserver: bfin: new port References: <1291886957-12003-1-git-send-email-vapier@gentoo.org> <201012141157.49676.vapier@gentoo.org> <4D07A65D.2090000@codesourcery.com> <201012141225.34826.vapier@gentoo.org> <4D08AC60.9060307@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00298.txt.bz2 On 15/12/10 12:55, Mike Frysinger wrote: > code looks good ... but there's one slight problem. it is binding to > the format gdbserver itself is being compiled as. in other words, > this code requires gdbserver itself to be compiled as FDPIC in order > to debug FDPIC applications. the current Blackfin code does not have > that restriction ... a FLAT gdbserver can debug a FDPIC app just fine. > > but it seems this limitation is superfluous ... how about we change > the __FDPIC__ ifdef to: > #if defined(PTRACE_GETFDPIC_EXEC)&& defined(PTRACE_GETFDPIC_INTERP) > ... > #endif Seems fine to me. > do you have an idea of when you'll submit just the qXfer:fdpic support > ? seems that these pieces can stand on their own just fine. I had not planned to submit it until I had the whole thing working. Given that the kernel was badly broken, last time I checked, I couldn't do it then, and I haven't had time since. Nor am I likely to have time to do more work on this in the foreseeable future. Feel free to take the patch and do what you like with it. It's just a matter of cutting out the non-gdbserver bits anyway. Andrew