From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3404 invoked by alias); 10 Dec 2010 15:21:35 -0000 Received: (qmail 3392 invoked by uid 22791); 10 Dec 2010 15:21:34 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Dec 2010 15:21:30 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBAFLT3N005112 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 10 Dec 2010 10:21:29 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oBAFLQWG029051 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 10 Dec 2010 10:21:28 -0500 Message-ID: <4D024576.4050603@redhat.com> Date: Fri, 10 Dec 2010 15:21:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc13 Lightning/1.0b3pre Thunderbird/3.1.6 MIME-Version: 1.0 To: Jan Kratochvil CC: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] c++/11734 revisited References: <4D002672.5090504@redhat.com> <20101209215230.GA14348@host0.dyn.jankratochvil.net> In-Reply-To: <20101209215230.GA14348@host0.dyn.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00140.txt.bz2 On 12/09/2010 01:52 PM, Jan Kratochvil wrote: >> Keith> +if {[get_compiler_info $binfile "c++"]} { >> Keith> + return -1 >> Keith> +} > If the reason was get_compiler_info it does not use $binfile anyway. > (And a lot of gdb testsuite code expects so.) I admit, I copy & pasted that bit from other gdb.cp tests. I'm not even sure why it is necessary, since we have skip_cplus_tests already. Is there any case where we would not have a C++ compiler and skip_cplus_tests != true? For now, I've simply removed this and converted the whole thing over to using prepare_for_testing. I noted one or two other gdb.cp tests which don't check get_compiler_info. Keith