From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12081 invoked by alias); 9 Dec 2010 09:01:37 -0000 Received: (qmail 12069 invoked by uid 22791); 9 Dec 2010 09:01:36 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Dec 2010 09:01:31 +0000 Received: (qmail 13546 invoked from network); 9 Dec 2010 09:01:29 -0000 Received: from unknown (HELO ?192.168.0.102?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Dec 2010 09:01:29 -0000 Message-ID: <4D009AE4.9070606@codesourcery.com> Date: Thu, 09 Dec 2010 09:01:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.15) Gecko/20101027 Thunderbird/3.0.10 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [RFC] mips-tdep.c: Update mips_register_to_value(), et al... References: <20101208164657.7d9ce88e@mesquite.lan> In-Reply-To: <20101208164657.7d9ce88e@mesquite.lan> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00105.txt.bz2 On 12/09/2010 07:46 AM, Kevin Buettner wrote: > (Can anyone think of better names for the two new functions that I > introduced?) > > * mips-tdep.c (big_endian_4_byte_fp_reg_with_double_type_p) > (eight_byte_gp_reg_with_shorter_type_p): New functions. Names of these two new functions are a little bit long. :-) Sometimes, it is hard to describe function's behavior only by its name. Can we name them as mips_convert_register_p_{1,2}, and give comments in details to each of them? -- Yao (齐尧)