Re: [commit]: dw2_expand_symtabs_with_filename: ignore type units

Doug Evans
2010-12-08T18:16:51Z

On Wed, Dec 8, 2010 at 10:10 AM, Doug Evans <dje@google.com> wrote:
> Hi.
>
> fyi, I checked this in.
>
> A supplemental patch is to rename expand_symtabs_with_filename.
> expand_code_symtabs_with_filename?
> Let me know if you want this change too.
>
> Btw, prior to this patch "break main" on one program here
> expanded gdb's memory usage by 2.5G.  :-)
>
> 2010-12-08  Doug Evans  <dje@google.com>
>
>        * symfile.h (quick_symbol_functions): Clarify usage of
>        expand_symtabs_with_filename.
>        * dwarf2read.c (dw2_expand_symtabs_with_filename): Only iterate over
>        comp units, not type units.

btw, for future reference,
TUs (DW_TAG_type_unit) can share line tables.
E.g. a program may have 95000 TUs but there may be only 5000 line
tables for all of them.
There may be more work that's needed here, and going forward we'll
want to support such sharing.