From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22802 invoked by alias); 29 Nov 2010 23:09:33 -0000 Received: (qmail 22793 invoked by uid 22791); 29 Nov 2010 23:09:32 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 29 Nov 2010 23:09:27 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id D3D042B004 for ; Mon, 29 Nov 2010 15:09:23 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id C15FBCD928 for ; Mon, 29 Nov 2010 15:09:23 -0800 (PST) Message-ID: <4CF432A3.5030306@vmware.com> Date: Mon, 29 Nov 2010 23:09:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101103) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [RFA] Skip tests if floating point not supported. Content-Type: multipart/mixed; boundary="------------010704080104020601040501" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00484.txt.bz2 This is a multi-part message in MIME format. --------------010704080104020601040501 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 78 Here are some tests that fail if the target does not support floating point. --------------010704080104020601040501 Content-Type: text/plain; name="float.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="float.txt" Content-length: 4624 2010-11-29 Michael Snyder * gdb.base/callfuncs.exp: Test for skip_float_tests. * gdb.base/call-sc.exp: Ditto. * gdb.base/finish.exp: Ditto. * gdb.base/return.exp: Ditto. * gdb.base/return2.exp: Ditto. Index: gdb.base/callfuncs.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/callfuncs.exp,v retrieving revision 1.38 diff -u -p -r1.38 callfuncs.exp --- gdb.base/callfuncs.exp 10 Jun 2010 19:48:19 -0000 1.38 +++ gdb.base/callfuncs.exp 29 Nov 2010 22:58:30 -0000 @@ -229,10 +229,14 @@ proc do_function_calls {} { "call inferior func with struct - returns int" gdb_test "p t_structs_l(struct_val1)" "= 51" \ "call inferior func with struct - returns long" - gdb_test "p t_structs_f(struct_val1)" "= 2.12.*" \ - "call inferior func with struct - returns float" - gdb_test "p t_structs_d(struct_val1)" "= 9.87.*" \ - "call inferior func with struct - returns double" + + if ![target_info exists gdb,skip_float_tests] { + gdb_test "p t_structs_f(struct_val1)" "= 2.12.*" \ + "call inferior func with struct - returns float" + gdb_test "p t_structs_d(struct_val1)" "= 9.87.*" \ + "call inferior func with struct - returns double" + } + gdb_test "p t_structs_a(struct_val1)" "= (.unsigned char .. )?\"foo\"" \ "call inferior func with struct - returns char *" } Index: gdb.base/call-sc.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/call-sc.exp,v retrieving revision 1.15 diff -u -p -r1.15 call-sc.exp --- gdb.base/call-sc.exp 1 Jun 2010 21:29:21 -0000 1.15 +++ gdb.base/call-sc.exp 29 Nov 2010 22:58:30 -0000 @@ -440,20 +440,22 @@ start_scalars_test tll test_scalar_calls test_scalar_returns -# Approx size: 4, 8, ... -start_scalars_test tf -test_scalar_calls -test_scalar_returns +if ![target_info exists gdb,skip_float_tests] { + # Approx size: 4, 8, ... + start_scalars_test tf + test_scalar_calls + test_scalar_returns -# Approx size: 8, 16, ... -start_scalars_test td -test_scalar_calls -test_scalar_returns + # Approx size: 8, 16, ... + start_scalars_test td + test_scalar_calls + test_scalar_returns -# Approx size: 16, 32, ... -start_scalars_test tld -test_scalar_calls -test_scalar_returns + # Approx size: 16, 32, ... + start_scalars_test tld + test_scalar_calls + test_scalar_returns +} # Approx size: 4, 8, ... start_scalars_test te Index: gdb.base/finish.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/finish.exp,v retrieving revision 1.18 diff -u -p -r1.18 finish.exp --- gdb.base/finish.exp 24 May 2010 22:06:59 -0000 1.18 +++ gdb.base/finish.exp 29 Nov 2010 22:58:30 -0000 @@ -103,8 +103,10 @@ proc finish_tests { } { finish_1 "int" finish_1 "long" finish_1 "long_long" - finish_1 "float" - finish_1 "double" + if ![target_info exists gdb,skip_float_tests] { + finish_1 "float" + finish_1 "double" + } finish_abbreviation "fin" } Index: gdb.base/return.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/return.exp,v retrieving revision 1.14 diff -u -p -r1.14 return.exp --- gdb.base/return.exp 10 Jun 2010 19:48:19 -0000 1.14 +++ gdb.base/return.exp 29 Nov 2010 22:58:30 -0000 @@ -89,7 +89,10 @@ proc return_tests { } { # is not xfailed. setup_xfail "sparc-*-solaris2.3*" "sparc-*-solaris2.4*" "m6811-*-*" - gdb_test "p tmp3" ".* = 5.*" "correct value returned double test (known problem with sparc solaris)" + if ![target_info exists gdb,skip_float_tests] { + gdb_test "p tmp3" ".* = 5.*" \ + "correct value returned double test (known problem with sparc solaris)" + } } set prev_timeout $timeout Index: gdb.base/return2.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/return2.exp,v retrieving revision 1.14 diff -u -p -r1.14 return2.exp --- gdb.base/return2.exp 27 May 2010 23:44:51 -0000 1.14 +++ gdb.base/return2.exp 29 Nov 2010 22:58:30 -0000 @@ -98,9 +98,11 @@ proc return2_tests { } { if { ! [istarget "m6811-*-*"] && ![istarget "h8300*-*"] } then { return_1 "long_long" } - return_1 "float" - if { ! [istarget "m6811-*-*"] } then { - return_1 "double" + if ![target_info exists gdb,skip_float_tests] { + return_1 "float" + if { ! [istarget "m6811-*-*"] } then { + return_1 "double" + } } } --------------010704080104020601040501--