Re: [PATCH] testsuite: asm-source.exp: add powerpc64 support

Edjunior Barbosa Machado
2010-11-10T13:01:42Z

Hi

On 11/10/2010 05:45 AM, Mark Kettenis wrote:
>> From: Edjunior Barbosa Machado<emachado@linux.vnet.ibm.com>
>> Date: Wed, 10 Nov 2010 05:29:42 -0200
>>
>> Hi,
>>
>> this patch intents to add powerpc64 support to the asm-source.exp
>> testcase. It contains a new include file (powerpc64.inc) which
>> defines macros for ppc64 asm. As some architectures (like ppc64)
>> can have one or more instructions after the subroutine call, the
>> testcase was modified in order to expect the caller line again as
>> well as the next line when issuing "finish" or "return" (as
>> mentioned at http://sourceware.org/ml/gdb/2010-11/msg00032.html).
>> It also has other minor changes, such as expect '.' prefixing
>> ppc64's symbols and call 'sys_exit' sequence on gdbasm_exit0 macro
>> for ppc32.
>>
>> Tested on x86, ppc32 and ppc64.
>>
>> Is that ok?
>
> Why are you making the distinction based on is_lp64_target and not on
> the target tuple (powerpc64*-*-* vs. powerpc*-*-*)?

is_lp64_target is necessary for when you running a 32-bit environment distro (such as RHEL5 and SLES10) in a ppc64 machine (it can not be distinguish by only checking the target tuple).

Thanks,
--
Edjunior