From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19894 invoked by alias); 10 Nov 2010 13:01:42 -0000 Received: (qmail 19804 invoked by uid 22791); 10 Nov 2010 13:01:40 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp01.br.ibm.com (HELO e24smtp01.br.ibm.com) (32.104.18.85) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Nov 2010 13:01:33 +0000 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by e24smtp01.br.ibm.com (8.14.4/8.13.1) with ESMTP id oAADJA1q008934 for ; Wed, 10 Nov 2010 11:19:10 -0200 Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oAAD0DgQ1597632 for ; Wed, 10 Nov 2010 10:00:13 -0300 Received: from d24av05.br.ibm.com (loopback [127.0.0.1]) by d24av05.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oAAD1LC3017955 for ; Wed, 10 Nov 2010 11:01:21 -0200 Received: from [9.8.10.199] ([9.8.10.199]) by d24av05.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id oAAD1Hbc017700; Wed, 10 Nov 2010 11:01:19 -0200 Message-ID: <4CDA9799.7050905@linux.vnet.ibm.com> Date: Wed, 10 Nov 2010 13:01:00 -0000 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.10) Gecko/20100619 Lightning/1.0b1 Icedove/3.0.5 MIME-Version: 1.0 To: Mark Kettenis CC: gdb-patches@sourceware.org Subject: Re: [PATCH] testsuite: asm-source.exp: add powerpc64 support References: <1289374182-14133-1-git-send-email-emachado@linux.vnet.ibm.com> <201011100745.oAA7jFsJ019214@glazunov.sibelius.xs4all.nl> In-Reply-To: <201011100745.oAA7jFsJ019214@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00146.txt.bz2 Hi On 11/10/2010 05:45 AM, Mark Kettenis wrote: >> From: Edjunior Barbosa Machado >> Date: Wed, 10 Nov 2010 05:29:42 -0200 >> >> Hi, >> >> this patch intents to add powerpc64 support to the asm-source.exp >> testcase. It contains a new include file (powerpc64.inc) which >> defines macros for ppc64 asm. As some architectures (like ppc64) >> can have one or more instructions after the subroutine call, the >> testcase was modified in order to expect the caller line again as >> well as the next line when issuing "finish" or "return" (as >> mentioned at http://sourceware.org/ml/gdb/2010-11/msg00032.html). >> It also has other minor changes, such as expect '.' prefixing >> ppc64's symbols and call 'sys_exit' sequence on gdbasm_exit0 macro >> for ppc32. >> >> Tested on x86, ppc32 and ppc64. >> >> Is that ok? > > Why are you making the distinction based on is_lp64_target and not on > the target tuple (powerpc64*-*-* vs. powerpc*-*-*)? is_lp64_target is necessary for when you running a 32-bit environment distro (such as RHEL5 and SLES10) in a ppc64 machine (it can not be distinguish by only checking the target tuple). Thanks, -- Edjunior