From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9766 invoked by alias); 7 Nov 2010 10:04:07 -0000 Received: (qmail 9755 invoked by uid 22791); 7 Nov 2010 10:04:06 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 07 Nov 2010 10:04:01 +0000 Received: (qmail 30783 invoked from network); 7 Nov 2010 10:03:59 -0000 Received: from unknown (HELO ?192.168.0.101?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 7 Nov 2010 10:03:59 -0000 Message-ID: <4CD6798B.4030308@codesourcery.com> Date: Sun, 07 Nov 2010 10:04:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.15) Gecko/20101027 Thunderbird/3.0.10 MIME-Version: 1.0 To: "Liu, Lei" CC: gdb-patches@sourceware.org Subject: Re: [PATCH] call cp_lookup_symbol_namespace recursively to search symbols in C++ base classes References: <4CCF89F0.5090100@windriver.com> <201011030009.47662.pedro@codesourcery.com> <4CD27431.30401@windriver.com> In-Reply-To: <4CD27431.30401@windriver.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00109.txt.bz2 On 11/04/2010 04:52 PM, Liu, Lei wrote: > > I updated my patch to deal with this as long as the suggestions from > Tom and Yao. > > I think in cp_set_block_scope, we should set scope name on a block > regardless of whether processing_has_namespace_info has been set. > For the cases that we only have classes but no namespaces, we still > need scope information to tell us which symbols are valid in a block. > > How about this? Lei, It looks like your mail client eats spaces and tabs when you paste your patch in your mail client. Please re-submit your patch again with following steps, 1. Run 'git diff' to generate patch and dump it to a file, named "foo.patch" for example, 2. Add your ChangeLog entry either in patch header or replied mail. 3. Reply mail in this thread, and *attach* your patch in your mail, and send it out. > + /* Just set the scope name if we get a valid one. */ Should be two spaces between "." and "*/". Please have a look at "16.1.3 Comments" in http://sourceware.org/gdb/current/onlinedocs/gdbint/Coding-Standards.html#Coding-Standards -- Yao Qi CodeSourcery yao@codesourcery.com (650) 331-3385 x739