From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26743 invoked by alias); 23 Sep 2010 16:13:47 -0000 Received: (qmail 26731 invoked by uid 22791); 23 Sep 2010 16:13:46 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Sep 2010 16:13:41 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8NGDcgd012714 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 23 Sep 2010 12:13:38 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8NGDcb0006346; Thu, 23 Sep 2010 12:13:38 -0400 Received: from [10.15.16.129] (dhcp-10-15-16-129.yyz.redhat.com [10.15.16.129]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o8NGDapC024647; Thu, 23 Sep 2010 12:13:37 -0400 Message-ID: <4C9B7CB1.7030208@redhat.com> Date: Thu, 23 Sep 2010 18:46:00 -0000 From: sami wagiaalla User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100806 Fedora/3.1.2-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.2 MIME-Version: 1.0 To: Tom Tromey CC: Doug Evans , gdb-patches@sourceware.org Subject: Re: [patch] PR 12028 "GDB crashes on a double free during overload resolution" References: <4C937E2D.80500@redhat.com> <4C9A2B89.4080601@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00409.txt.bz2 On 09/22/2010 03:19 PM, Tom Tromey wrote: >>>>>> "Sami" == sami wagiaalla writes: > > Sami> I agree. I have attached a patch which has been regression tested on > Sami> x8664 with gcc-4.4.4-10.fc13 > > This patch is also ok, assuming that it is still valgrind-clean for the > test in question. > I ran valgrind like this: valgrind ./gdb/gdb ./gdb/testsuite/gdb.cp/pr12028 -ex 'sta' -ex 'p D::foo(b)' -ex 'q' There are no glaring errors. The original double free error is still gone of course and there are no others. Incidentally, there is this error: ==8467== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 27 from 9) ==8467== Use of uninitialised value of size 8 ==8467== at 0x57C966: bcache_full (bcache.c:189) ==8467== by 0x52E94F: add_psymbol_to_list (psymtab.c:1358) ==8467== by 0x596634: add_partial_symbol (dwarf2read.c:3794) ==8467== by 0x596A7A: add_partial_subprogram (dwarf2read.c:3882) Worth figuring out but it is unrelated to this patch series. So I am committing the above patch.