From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32500 invoked by alias); 16 Sep 2010 22:31:01 -0000 Received: (qmail 32492 invoked by uid 22791); 16 Sep 2010 22:31:01 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Sep 2010 22:30:55 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 1FFD251008; Thu, 16 Sep 2010 15:30:53 -0700 (PDT) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 152BDCD955; Thu, 16 Sep 2010 15:30:53 -0700 (PDT) Message-ID: <4C929A9C.1050601@vmware.com> Date: Fri, 17 Sep 2010 08:33:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20100903) MIME-Version: 1.0 To: Jiang Jilin CC: Hui Zhu , gdb-patches ml , "tromey@redhat.com" Subject: Re: [PATCH] Rewrite the codes for opcode 0x0f01 and add more instructions support References: <1255182393-15292-1-git-send-email-freephp@gmail.com> <4AD28E95.1050404@vmware.com> <7d77a27d0910111921v13a8e8acpb98c29a9aa72ed8@mail.gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00314.txt.bz2 Since it is a pretty actively changing file, it would probably be good to supply a new diff and changelog, please. Hui, you should be one of the reviewers, yes? Jiang Jilin wrote: > Hi, > > I'm very sorry due to my work, however, it's good news that the I've > finished the paper assignment. > > Should I rewrite the patch again? Any comments are welcome! > > Thank you! > > On Mon, Oct 12, 2009 at 10:21 AM, Jiang Jilin wrote: >> On Mon, Oct 12, 2009 at 10:04 AM, Michael Snyder wrote: >>> Jiang Jilin wrote: >>>> Hi, guys >>>> >>>> I've rewrite the codes for opcode 0x0f01 with more readable, add >>>> xgetbv/xsetbv/rdtscp/vmcall/vmlaunch/vmresume/vmxoff instructions >>>> support as well. >>>> >>>> However, I'm *not* sure it's whether right or not, especially with >>>> the new supported instructions beginning with "vm". And I remove all >>>> codes to save EFLAGS register which is not specified to be saved by >>>> Intel's manual, so please help me review them. >>>> >>>> Luckily, there is no regression when using precord.exp board file to test. >>>> >>>> At last but not least, there is some differences in gdb.sum when >>>> 'make check' before and after applying this patch. I cannot make >>>> a decision whether it's correct, so please help me. The diff are >>>> as follows: >>> Ah well, but you see, now the change is too big to be accepted >>> without a copyright assignment. Do you want to start the process >>> of filing one? >> I've done as Joel told me, now I just wait for the paper arrival. >> >> Anyway, thank you! :) >> >>> [Cc: Tom Tromey] >>> >> -- >> Jiang >> > > >