From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8097 invoked by alias); 13 Sep 2010 15:04:21 -0000 Received: (qmail 8082 invoked by uid 22791); 13 Sep 2010 15:04:19 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Sep 2010 15:04:09 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8DF48mY014728 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 Sep 2010 11:04:08 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8DF47pd003849; Mon, 13 Sep 2010 11:04:08 -0400 Received: from [10.15.16.129] (dhcp-10-15-16-129.yyz.redhat.com [10.15.16.129]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o8DF47Uc026384; Mon, 13 Sep 2010 11:04:07 -0400 Message-ID: <4C8E3D52.5080005@redhat.com> Date: Mon, 13 Sep 2010 17:51:00 -0000 From: sami wagiaalla User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100806 Fedora/3.1.2-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.2 MIME-Version: 1.0 To: Jan Kratochvil CC: gdb-patches@sourceware.org Subject: Re: [patch] PR 11992 "Regression: C++ this scope sometimes does not work" References: <4C8A80A4.9060707@redhat.com> <20100911172806.GA23918@host1.dyn.jankratochvil.net> In-Reply-To: <20100911172806.GA23918@host1.dyn.jankratochvil.net> Content-Type: multipart/mixed; boundary="------------000102070501070908040802" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00247.txt.bz2 This is a multi-part message in MIME format. --------------000102070501070908040802 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 461 > [ I would not call it "gcc 4.4.4", it is gcc-4.4.4-10.fc13 which is far from > FSF GCC 4.4.4. ] > Gotcha! > Anyway while it fixes the problem for me on Fedora 13 x86_64 (and even others) > the testcase does not FAIL with FSF GDB HEAD (reproducing the problem from > Dodji as is in the PR). > You are right. My bad; I should not have missed that. I fixed the test case by giving the new functions their own unique names. I will commit the attached patch --------------000102070501070908040802 Content-Type: text/x-patch; name="this_regression.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="this_regression.patch" Content-length: 1973 Fix PR 11992: C++ 'this' scope sometimes does not work 2010-09-13 Sami Wagiaalla PR symtab/11992: * c-exp.y (classify_name): Check is_a_member_of_this before returning UNKNOWN_CPP_NAME. 2010-09-13 Sami Wagiaalla * gdb.cp/koenig.cc: created class for testing member lookup. * gdb.cp/koenig.exp: Added test for member lookup. diff --git a/gdb/c-exp.y b/gdb/c-exp.y index 663e778..57e09b3 100644 --- a/gdb/c-exp.y +++ b/gdb/c-exp.y @@ -2389,6 +2389,7 @@ classify_name (struct block *block) if (sym == NULL && parse_language->la_language == language_cplus + && !is_a_field_of_this && !lookup_minimal_symbol (copy, NULL, NULL)) return UNKNOWN_CPP_NAME; diff --git a/gdb/testsuite/gdb.cp/koenig.cc b/gdb/testsuite/gdb.cp/koenig.cc index c91dbf9..e2190f1 100644 --- a/gdb/testsuite/gdb.cp/koenig.cc +++ b/gdb/testsuite/gdb.cp/koenig.cc @@ -226,6 +226,16 @@ namespace P { //------------ +class R { + public: + int rfoo(){ return 31; } + int rbar(){ + return 1; // marker1 + } +}; + +//------------ + int main () { @@ -299,6 +309,10 @@ main () ++q; + R r; + r.rbar(); + r.rfoo(); + return first (0, c) + foo (eo) + foo (eo, eo) + foo (eo, eo, 1) + foo (fo, eo) + foo (1 ,fo, eo) + diff --git a/gdb/testsuite/gdb.cp/koenig.exp b/gdb/testsuite/gdb.cp/koenig.exp index d5e6c3f..34abe77 100644 --- a/gdb/testsuite/gdb.cp/koenig.exp +++ b/gdb/testsuite/gdb.cp/koenig.exp @@ -115,3 +115,14 @@ gdb_test "p q + 5" "= 29" # some unary operators for good measure # Cannot resolve function operator++ to any overloaded instance gdb_test "p ++q" "= 30" + +# Test that koening lookup does not affect +# member variable lookup. +gdb_test "p r.rfoo()" "= 31" + +# Do the same from inside class R. +gdb_breakpoint [gdb_get_line_number "marker1"] +gdb_continue_to_breakpoint "marker1" + +gdb_test "p rfoo()" "= 31" +gdb_test "p this->rfoo()" "= 31" --------------000102070501070908040802--