From: Nathan Sidwell <nathan@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: add enable-inprocess-agent configure option
Date: Thu, 09 Sep 2010 14:52:00 -0000 [thread overview]
Message-ID: <4C88D379.6000200@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
This patch adds explicit configure control over whether the
fast/static-tracepoint inprocess agent is built, on targets that support it.
Also, if you explicitly enable the agent, but the target does not support it,
you get a configure-time error.
ok?
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery
[-- Attachment #2: all.diff --]
[-- Type: text/plain, Size: 3340 bytes --]
2010-09-09 Nathan Sidwell <nathan@codesourcery.com>
* configure.ac: Add --enable-inprocess-agent option.
* configure: Rebuilt.
Index: gdb/gdbserver/configure.ac
===================================================================
--- gdb/gdbserver/configure.ac (revision 298677)
+++ gdb/gdbserver/configure.ac (working copy)
@@ -357,15 +357,35 @@ AC_COMPILE_IFELSE(AC_LANG_PROGRAM([]),
[gdbsrv_cv_have_visibility_hidden=no])
CFLAGS="$saved_cflags"
+
IPA_DEPFILES=""
+extra_libraries=""
-# Rather than allowing to build a broken IPA, we simply disable it if
-# we don't find a compiler supporting all the features we need.
+# check whether to enable the inprocess agent
if test "$ipa_obj" != "" \
-a "$gdbsrv_cv_have_sync_builtins" = yes \
-a "$gdbsrv_cv_have_visibility_hidden" = yes; then
- IPA_DEPFILES="$ipa_obj"
- extra_libraries="libinproctrace.so"
+ have_ipa=true
+else
+ have_ipa=false
+fi
+
+AC_ARG_ENABLE(inprocess-agent,
+AS_HELP_STRING([--enable-inprocess-agent], [inprocess agent]),
+[case "$enableval" in
+ yes) want_ipa=true ;;
+ no) want_ipa=false ;;
+ *) AC_MSG_ERROR([bad value $enableval for inprocess-agent]) ;;
+esac],
+[want_ipa=$have_ipa])
+
+if $want_ipa ; then
+ if $have_ipa ; then
+ IPA_DEPFILES="$ipa_obj"
+ extra_libraries="$extra_libraries libinproctrace.so"
+ else
+ AC_MSG_ERROR([inprocess agent not supported for this target])
+ fi
fi
AC_SUBST(GDBSERVER_DEPFILES)
Index: gdb/gdbserver/configure
===================================================================
--- gdb/gdbserver/configure (revision 298677)
+++ gdb/gdbserver/configure (working copy)
@@ -680,6 +680,7 @@ enable_werror
with_pkgversion
with_bugurl
with_libthread_db
+enable_inprocess_agent
'
ac_precious_vars='build_alias
host_alias
@@ -1309,6 +1310,8 @@ Optional Features:
--disable-FEATURE do not include FEATURE (same as --enable-FEATURE=no)
--enable-FEATURE[=ARG] include FEATURE [ARG=yes]
--enable-werror treat compile warnings as errors
+ --enable-inprocess-agent
+ inprocess agent
Optional Packages:
--with-PACKAGE[=ARG] use PACKAGE [ARG=yes]
@@ -4904,15 +4907,38 @@ fi
rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
CFLAGS="$saved_cflags"
+
IPA_DEPFILES=""
+extra_libraries=""
-# Rather than allowing to build a broken IPA, we simply disable it if
-# we don't find a compiler supporting all the features we need.
+# check whether to enable the inprocess agent
if test "$ipa_obj" != "" \
-a "$gdbsrv_cv_have_sync_builtins" = yes \
-a "$gdbsrv_cv_have_visibility_hidden" = yes; then
- IPA_DEPFILES="$ipa_obj"
- extra_libraries="libinproctrace.so"
+ have_ipa=true
+else
+ have_ipa=false
+fi
+
+# Check whether --enable-inprocess-agent was given.
+if test "${enable_inprocess_agent+set}" = set; then :
+ enableval=$enable_inprocess_agent; case "$enableval" in
+ yes) want_ipa=true ;;
+ no) want_ipa=false ;;
+ *) as_fn_error "bad value $enableval for inprocess-agent" "$LINENO" 5 ;;
+esac
+else
+ want_ipa=$have_ipa
+fi
+
+
+if $want_ipa ; then
+ if $have_ipa ; then
+ IPA_DEPFILES="$ipa_obj"
+ extra_libraries="$extra_libraries libinproctrace.so"
+ else
+ as_fn_error "inprocess agent not supported for this target" "$LINENO" 5
+ fi
fi
next reply other threads:[~2010-09-09 12:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 14:52 Nathan Sidwell [this message]
2010-09-09 14:56 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C88D379.6000200@codesourcery.com \
--to=nathan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox