From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74860-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21474 invoked by alias); 11 Aug 2010 13:16:35 -0000
Received: (qmail 21342 invoked by uid 22791); 11 Aug 2010 13:16:33 -0000
X-SWARE-Spam-Status: No, hits=-5.5 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Aug 2010 13:16:24 +0000
Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7BDG5ew015932	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 11 Aug 2010 09:16:05 -0400
Received: from Phil-THINK.home (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7BDG2Pg021340;	Wed, 11 Aug 2010 09:16:03 -0400
Message-ID: <4C62A292.6030702@redhat.com>
Date: Wed, 11 Aug 2010 13:16:00 -0000
From: Phil Muldoon <pmuldoon@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Thunderbird/3.1.1
MIME-Version: 1.0
To: gdb-patches ml <gdb-patches@sourceware.org>
CC: Tom Tromey <tromey@redhat.com>, Joel Brobecker <brobecker@adacore.com>,        Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] Add solib_address and decode_line Python functionality
References: <4C44728D.4040408@redhat.com> <20100727162545.GF13267@adacore.com>	<4C5015E2.4000205@redhat.com> <m3fwz2ja5v.fsf@fleche.redhat.com>	<4C5C1418.7030607@redhat.com> <m3d3tvqsca.fsf@fleche.redhat.com>	<4C613540.9090009@redhat.com> <m3tyn2comu.fsf@fleche.redhat.com>
In-Reply-To: <m3tyn2comu.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-08/txt/msg00142.txt.bz2

On 10/08/10 19:24, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

> Eli> This is okay, but I would suggest to explain what happens without the
> Eli> argument first.  Readers shouldn't need to read all the description of
> Eli> how the argument is parsed if they don't want to pass it.
> 
> Phil> > I've used your re-ordering in this patch, too.
> 
> Eli> I'm happy now.  Thanks.
> 
 
> Tom> So, could you make this conditional?
> 
> Phil> Sure, what do you think of the attached patch?
> 
> Tom> Thanks for persevering.  This is ok.


So committed. Thanks

http://sourceware.org/ml/gdb-cvs/2010-08/msg00051.html

Cheers,

Phil