From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73752-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8786 invoked by alias); 15 Jun 2010 17:44:37 -0000
Received: (qmail 8771 invoked by uid 22791); 15 Jun 2010 17:44:36 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jun 2010 17:44:29 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167])	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 7DF8C5400D;	Tue, 15 Jun 2010 10:44:27 -0700 (PDT)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost2.vmware.com (Postfix) with ESMTP id 715C68E7D9;	Tue, 15 Jun 2010 10:44:27 -0700 (PDT)
Message-ID: <4C17BBFB.8010806@vmware.com>
Date: Tue, 15 Jun 2010 17:44:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.22 (X11/20090609)
MIME-Version: 1.0
To: Frederic Riss <frederic.riss@gmail.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [resubmit] gdb.base, r*.exp thru w*.exp
References: <4BF59BBB.8020603@vmware.com> <AANLkTimG38HTcyRN2hr5If0lcUCHY_84j3V_JmEne-Ha@mail.gmail.com>
In-Reply-To: <AANLkTimG38HTcyRN2hr5If0lcUCHY_84j3V_JmEne-Ha@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-06/txt/msg00345.txt.bz2

Could you identify the subset of changes that behave erratically for you?

Frederic Riss wrote:
> Hi,
> 
> I get some strange issues with this series of commits. Some tests
> start to randomly fail. It's quite hard to reproduce, I only have 1
> out of ~10 boxes that exposes the issue in an random manner. To take a
> real example, let's take this hunk:
> 
> On 20 May 2010 22:29, Michael Snyder <msnyder@vmware.com> wrote:
>> Index: setshow.exp
>> --- setshow.exp 5 May 2010 18:06:58 -0000       1.14
>> +++ setshow.exp 20 May 2010 20:24:11 -0000
>> @@ -54,27 +54,25 @@ if { ![runto_main] } {
>>  #test set annotate 2
>> -send_gdb "set annotate 2\n"
>> -gdb_expect {
>> -       -re ".*\032\032pre-prompt.*$gdb_prompt .*\032\032prompt.*$" \
>> -                               { pass "set annotate 2" }
>> -       timeout                 { fail "(timeout) set annotate 2" }
>> +
>> +gdb_test_multiple "set annotate 2" "set annotate 2" {
>> +    -re ".*\032\032pre-prompt.*$gdb_prompt .*\032\032prompt.*$" {
>> +    pass "set annotate 2"
>>     }
>> +}
> 
> Before that commit, the test seemed 100% reliable. After the commit,
> if I run it in a loop on the affected box, I start to get failures
> like that in my runs:
> 
> set annotate 2
> 
> ^Z^Zpre-prompt
> (gdb) FAIL: gdb.base/setshow.exp: set annotate 2
> 
> ^Z^Zprompt
> 
> As you see the required things are in the output, but expect fails to
> match it;. There must be some subtle difference between gdb_expect and
> gdb_test_multiple when matching patterns containing prompts. Does that
> make any sense to someone? Note that I took this precise example, but
> I have a few places in the testsuite that show similar random
> failures.
> 
> Thanks,
> Fred