From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73699-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11278 invoked by alias); 11 Jun 2010 22:47:09 -0000
Received: (qmail 11269 invoked by uid 22791); 11 Jun 2010 22:47:08 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Jun 2010 22:47:04 +0000
Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45])	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 8C1E34B063;	Fri, 11 Jun 2010 15:47:03 -0700 (PDT)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost3.vmware.com (Postfix) with ESMTP id 8A1E7CD905;	Fri, 11 Jun 2010 15:47:03 -0700 (PDT)
Message-ID: <4C12BCE7.7010403@vmware.com>
Date: Fri, 11 Jun 2010 22:47:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.22 (X11/20090609)
MIME-Version: 1.0
To: Ulrich Weigand <uweigand@de.ibm.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,  Pedro Alves <pedro@codesourcery.com>
Subject: Re: [RFA] gdb.trace, replace wildcard regexp
References: <201006111701.o5BH1tlT007147@d12av02.megacenter.de.ibm.com>
In-Reply-To: <201006111701.o5BH1tlT007147@d12av02.megacenter.de.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-06/txt/msg00292.txt.bz2

Ulrich Weigand wrote:
> Michael Snyder wrote:
> 
>> --- gdb.trace/packetlen.exp	2 Jun 2010 21:55:28 -0000	1.14
>> +++ gdb.trace/packetlen.exp	4 Jun 2010 18:02:31 -0000
>> @@ -34,8 +34,8 @@ if { [gdb_compile "$srcdir/$subdir/$srcf
>>      return -1
>>  }
>>  gdb_load $binfile
>> -gdb_test "tstop"       "" ""
>> -gdb_test "tfind none"  "" ""
>> +gdb_test "tstop"       ".*" ""
>> +gdb_test "tfind none"  ".*" ""
>>  runto_main
>>  gdb_reinitialize_dir $srcdir/$subdir
>>  
>> @@ -48,7 +48,7 @@ gdb_reinitialize_dir $srcdir/$subdir
>>  #
>>  
>>  gdb_delete_tracepoints
>> -gdb_test "trace gdb_c_test" "" ""
>> +gdb_test "trace gdb_c_test" ".*" ""
>>  gdb_trace_setactions "setup collect actions" \
>>  	"" \
>>  	"collect parm\[0\], parm\[1\], parm\[2\], parm\[3\]" "^$" \
>> @@ -61,7 +61,7 @@ gdb_trace_setactions "setup collect acti
>>  	"end" ""
>>  
>>  gdb_test_no_output "tstart" "survive the long packet send"
>> -gdb_test "break end" "" ""
>> +gdb_test "break end" ".*" ""
>>  gdb_test "continue" \
>>      "Continuing.*Breakpoint $decimal, end.*" \
>>      "run trace experiment"
> 
> This change also causes new FAILs for me:
> 
> (gdb) PASS: gdb.trace/packetlen.exp: setup collect actions
> tstart^M
> You can't do that when your target is `child'^M
> (gdb) FAIL: gdb.trace/packetlen.exp: survive the long packet send
> break end^M
> Breakpoint 3 at 0x760: file /home/uweigand/fsf/gdb-head/gdb/testsuite/gdb.trace/actions.c, line 110.^M
> (gdb) continue^M
> Continuing.^M
> ^M
> Breakpoint 3, end () at /home/uweigand/fsf/gdb-head/gdb/testsuite/gdb.trace/actions.c:110^M
> 110     }^M
> (gdb) PASS: gdb.trace/packetlen.exp: run trace experiment
> tstop^M
> Trace is not running.^M
> (gdb) FAIL: gdb.trace/packetlen.exp: confirm: survived the long packet send

Yeah, but these ones really do fail, when the target can't do
tracepoints.  They need to be run against gdbserver.

Odd, though, most of the trace tests bail early if the target
can't do tracepoints.  They don't give arbitrary failures...