Sorry about that... cm On 06/04/10 16:14, Jan Kratochvil wrote: > On Fri, 04 Jun 2010 19:24:05 +0200, Chris Moller wrote: > >> + if (b->type != bp_watchpoint&& b->type != bp_hardware_watchpoint&& >> + b->enable_state != bp_call_disabled) >> > > `&&' should be on the second line. > http://www.gnu.org/prep/standards/standards.html#Formatting > When you split an expression into multiple lines, split it before an > operator, not after one. > > > >> +Running ../../../src/gdb/testsuite/gdb.base/pr11371.exp ... >> +PASS: gdb.base/pr11371.exp: watch aa if cond(aa) >> +PASS: gdb.base/pr11371.exp: run to conditional watchpoint >> +PASS: gdb.base/pr11371.exp: run to conditional watchpoint >> +PASS: gdb.base/pr11371.exp: run to conditional watchpoint >> > > Apparently you have written a new testcase but forgot to attach it. > I have not tried to do real a review without the testcase. > > > Thanks, > Jan >