From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73439-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19634 invoked by alias); 1 Jun 2010 22:23:34 -0000
Received: (qmail 19619 invoked by uid 22791); 1 Jun 2010 22:23:33 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Jun 2010 22:23:22 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167])	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 465BA2300C;	Tue,  1 Jun 2010 15:23:21 -0700 (PDT)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost2.vmware.com (Postfix) with ESMTP id 3C6D68E857;	Tue,  1 Jun 2010 15:23:21 -0700 (PDT)
Message-ID: <4C058858.1070707@vmware.com>
Date: Tue, 01 Jun 2010 22:23:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.22 (X11/20090609)
MIME-Version: 1.0
To: Joel Brobecker <brobecker@adacore.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdb.threads/*.exp: send_gdb vs. gdb_test
References: <4BFDBBFB.8030503@vmware.com> <20100601214837.GS3019@adacore.com>
In-Reply-To: <20100601214837.GS3019@adacore.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-06/txt/msg00032.txt.bz2

Joel Brobecker wrote:
>> 2010-05-26  Michael Snyder  <msnyder@msnyder-server.eng.vmware.com>
>>
>> 	* gdb.threads/attach-stopped.exp: Replace send_gdb with gdb_test.
>> 	* gdb.threads/attachstop-mt.exp: Replace send_gdb with gdb_test.
>> 	* gdb.threads/gcore-thread.exp: Replace send_gdb with gdb_test.
>> 	* gdb.threads/hand-call-in-threads.exp: Replace send_gdb with gdb_test.
>> 	* gdb.threads/linux-dp.exp: Replace send_gdb with gdb_test.
>> 	* gdb.threads/print-threads.exp: Replace send_gdb with gdb_test.
>> 	* gdb.threads/pthreads.exp: Replace send_gdb with gdb_test.
>> 	* gdb.threads/schedlock.exp: Replace send_gdb with gdb_test.
>> 	* gdb.threads/sigthread.exp: Replace send_gdb with gdb_test.
> 
> Looks fine to me. Just one observation...
> 
> 
>> Index: pthreads.exp
> [...]
>> -    send_gdb "continue\n"
>> -    gdb_expect {
>> -	-re "Continuing.*common_routine.*at.*$srcfile.*$gdb_prompt $" {}
>> +    gdb_test_multiple "continue" "continue until common routine run 15 times" {
>> +	-re "Continuing.*common_routine.*at.*$srcfile.*$gdb_prompt $" {
>> +	}
>>  	default {
>>  	    fail "continue until common routine run 15 times"
>>  	    return 0
> 
> Shouldn't we delete the "default" & "timeout" sections in this case?

I left them in because they do a "return", which wouldn't happen
if they were removed.