From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10471 invoked by alias); 1 Jun 2010 21:30:23 -0000 Received: (qmail 10463 invoked by uid 22791); 1 Jun 2010 21:30:22 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Jun 2010 21:30:09 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id B73295; Tue, 1 Jun 2010 14:30:05 -0700 (PDT) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id A7127CD902; Tue, 1 Jun 2010 14:30:05 -0700 (PDT) Message-ID: <4C057BDD.4010600@vmware.com> Date: Tue, 01 Jun 2010 21:30:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.22 (X11/20090609) MIME-Version: 1.0 To: Joel Brobecker CC: "gdb-patches@sourceware.org" Subject: Re: [RFA] gdb.base -- use gdb_test_no_output References: <4C02A794.70703@vmware.com> <20100601194336.GP3019@adacore.com> In-Reply-To: <20100601194336.GP3019@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00024.txt.bz2 Joel Brobecker wrote: >> 2010-05-30 Michael Snyder >> >> * gdb.base/arithmet.exp: Use gdb_test_no_output. >> * gdb.base/arrayidx.exp: Ditto. >> * gdb.base/attach.exp: Ditto. >> * gdb.base/auxv.exp: Ditto. >> * gdb.base/bigcre.exp: Ditto. >> * gdb.base/break-always.exp: Ditto. >> * gdb.base/break-interp.exp: Ditto. >> * gdb.base/break.exp: Ditto. >> * gdb.base/breakpoint-shadow.exp: Ditto. >> * gdb.base/call-ar-st.exp: Ditto. >> * gdb.base/call-sc.exp: Ditto. >> * gdb.base/call-signal-resume.exp: Ditto. >> * gdb.base/callfuncs.exp: Ditto. >> * gdb.base/catch-syscall.exp: Ditto. >> * gdb.base/charset.exp: Ditto. >> * gdb.base/code-expr.exp: Ditto. >> * gdb.base/commands.exp: Ditto. >> * gdb.base/cond-expr.exp: Ditto. >> * gdb.base/condbreak.exp: Ditto. >> * gdb.base/cursal.exp: Ditto. >> * gdb.base/cvexpr.exp: Ditto. >> * gdb.base/default.exp: Ditto. >> * gdb.base/del.exp: Ditto. >> * gdb.base/detach.exp: Ditto. >> * gdb.base/display.exp: Ditto. >> * gdb.base/ena-dis-br.exp: Ditto. >> * gdb.base/eval-skip.exp: Ditto. >> * gdb.base/foll-fork.exp: Ditto. >> * gdb.base/foll-vfork.exp: Ditto. >> * gdb.base/frame-args.exp: Ditto. >> * gdb.base/funcargs.exp: Ditto. >> * gdb.base/gcore-buffer-overflow.exp: Ditto. >> * gdb.base/gdbvars.exp: Ditto. >> * gdb.base/help.exp: Ditto. >> * gdb.base/ifelse.exp: Ditto. >> * gdb.base/included.exp: Ditto. >> * gdb.base/list.exp: Ditto. >> * gdb.base/macscp.exp: Ditto. >> * gdb.base/maint.exp: Ditto. >> * gdb.base/multi-fork.exp: Ditto. >> * gdb.base/overlays.exp: Ditto. >> * gdb.base/page.exp: Ditto. >> * gdb.base/pending.exp: Ditto. >> * gdb.base/pointers.exp: Ditto. >> * gdb.base/pr11022.exp: Ditto. >> * gdb.base/prelink.exp: Ditto. >> * gdb.base/printcmds.exp: Ditto. >> * gdb.base/psymtab.exp: Ditto. >> * gdb.base/randomize.exp: Ditto. >> * gdb.base/relational.exp: Ditto. >> * gdb.base/relocate.exp: Ditto. >> * gdb.base/remote.exp: Ditto. >> * gdb.base/sepdebug.exp: Ditto. >> * gdb.base/set-lang-auto.exp: Ditto. >> * gdb.base/setshow.exp: Ditto. >> * gdb.base/setvar.exp: Ditto. >> * gdb.base/signals.exp: Ditto. >> * gdb.base/signull.exp: Ditto. >> * gdb.base/sigstep.exp: Ditto. >> * gdb.base/sizeof.exp: Ditto. >> * gdb.base/solib-disc.exp: Ditto. >> * gdb.base/store.exp: Ditto. >> * gdb.base/structs.exp: Ditto. >> * gdb.base/structs2.exp: Ditto. >> * gdb.base/subst.exp: Ditto. >> * gdb.base/term.exp: Ditto. >> * gdb.base/trace-commands.exp: Ditto. >> * gdb.base/unwindonsignal.exp: Ditto. >> * gdb.base/valgrind-db-attach.exp: Ditto. >> * gdb.base/varargs.exp: Ditto. >> * gdb.base/watch-cond.exp: Ditto. >> * gdb.base/watch_thread_num.exp: Ditto. >> * gdb.base/watchpoint-cond-gone.exp: Ditto. >> * gdb.base/watchpoint.exp: Ditto. >> * gdb.base/whatis-exp.exp: Ditto. > > I went through 60% of the diff before I gave up. That first 60% looked > good to me. Given that it's relatively mechanical, and if you tested it > and found no difference, I think we can assume that the rest is OK too. > > Thanks for doing this, Thanks for the review. Committed.