From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29817 invoked by alias); 1 Jun 2010 19:21:50 -0000 Received: (qmail 29809 invoked by uid 22791); 1 Jun 2010 19:21:49 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Jun 2010 19:21:39 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o51JLbVe009434 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 1 Jun 2010 15:21:38 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o51JLXop007241 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 1 Jun 2010 15:21:36 -0400 Message-ID: <4C055DBD.7040300@redhat.com> Date: Tue, 01 Jun 2010 19:21:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 MIME-Version: 1.0 To: gdb-patches@sourceware.org CC: sami wagiaalla Subject: Re: [patch] Remove redundant symbol naming from new_symbol References: <4BFE83F0.2090908@redhat.com> In-Reply-To: <4BFE83F0.2090908@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00015.txt.bz2 On 05/27/2010 07:38 AM, sami wagiaalla wrote: > This patch removes the redundant calls. FWIW, I think this patch should be approved; the additional calls to dwarf2_full_name do appear to be redundant, since SYMBOL_SET_NAMES is called unconditionally for every symbol with DW_AT_name. [The only question is whether dwarf2_full_name and dwarf2_physname could return different "names" for these DIEs, and since the DIEs do not represent a class method, the "names" will be identical.] Keith