From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73319-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8933 invoked by alias); 26 May 2010 18:17:47 -0000
Received: (qmail 8921 invoked by uid 22791); 26 May 2010 18:17:46 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 May 2010 18:17:37 +0000
Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45])	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id A8CCF4005;	Wed, 26 May 2010 11:17:33 -0700 (PDT)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost3.vmware.com (Postfix) with ESMTP id 9E77ACD911;	Wed, 26 May 2010 11:17:33 -0700 (PDT)
Message-ID: <4BFD65BD.50204@vmware.com>
Date: Wed, 26 May 2010 18:26:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.22 (X11/20090609)
MIME-Version: 1.0
To: Joel Brobecker <brobecker@adacore.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdb.gdb/*.exp send_gdb vs. gdb_test
References: <4BFC4117.5020003@vmware.com> <20100526175743.GD3019@adacore.com>
In-Reply-To: <20100526175743.GD3019@adacore.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00612.txt.bz2

Joel Brobecker wrote:
>> 2010-05-25  Michael Snyder  <msnyder@vmware.com>
>>
>> 	* gdb.gdb/complaints.exp: Replace send_gdb with gdb_test.
>> 	* gdb.gdb/selftest.exp: Replace send_gdb with gdb_test.
>> 	* gdb.gdb/xfullpath.exp: Replace send_gdb with gdb_test.
> 
> Same question as before: Can you double-check that gdb_test cannot
> be used in the cases below? If not, OK to commit.
> 
>>      # Add a second complaint, expect it
>> -    send_gdb "call complaint (&symfile_complaints, \"serial line 2\")\n"
>> -    gdb_expect {
>> +    gdb_test_multiple "call complaint (&symfile_complaints, \"serial line 2\")" "serial line 2" {
>>  	-re "serial line 2...$gdb_prompt " {

Can't use gdb_test because the usual CR/LF are missing from in front of 
$gdb_prompt.

>>  	    pass "serial line 2"
>>  	}
>> -	"$gdb_prompt" {
>> -	    fail "serial line 2"
>> -	}
>> -	timeout {
>> -	    fail "serial line 2 (timeout)"
>> -	}
> 
> Can we use gdb_test here?
> 
>> -    send_gdb "call complaint (&symfile_complaints, \"short line 1\")\n"
>> -    gdb_expect {
>> +    gdb_test_multiple "call complaint (&symfile_complaints, \"short line 1\")" "short line 1" {
>>  	-re "short line 1...$gdb_prompt " {

Ditto.

>>  	    pass "short line 1"
> 
> Ditto?
> 
>>      # Add a second complaint, expect it
>> -    send_gdb "call complaint (&symfile_complaints, \"short line 2\")\n"
>> -    gdb_expect {
>> +    gdb_test_multiple "call complaint (&symfile_complaints, \"short line 2\")" "short line 2" {
> 
> Ditto again.

Ditto again.