From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73305-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27896 invoked by alias); 26 May 2010 17:05:23 -0000
Received: (qmail 27785 invoked by uid 22791); 26 May 2010 17:05:22 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 May 2010 17:05:12 +0000
Received: from jupiter.vmware.com (mailhost5.vmware.com [10.16.68.131])	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 2D2B459009;	Wed, 26 May 2010 10:05:10 -0700 (PDT)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by jupiter.vmware.com (Postfix) with ESMTP id 23E60DC168;	Wed, 26 May 2010 10:05:10 -0700 (PDT)
Message-ID: <4BFD54C5.4060409@vmware.com>
Date: Wed, 26 May 2010 17:07:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.22 (X11/20090609)
MIME-Version: 1.0
To: Vladimir Prus <vladimir@codesourcery.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdb.mi/*.exp, send_gdb vs. gdb_test
References: <4BFC6CF2.1090103@vmware.com> <201005260844.17679.vladimir@codesourcery.com>
In-Reply-To: <201005260844.17679.vladimir@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00598.txt.bz2

Vladimir Prus wrote:
> On Wednesday 26 May 2010 04:36:02 Michael Snyder wrote:
> 
>> -    send_gdb "-gdb-version\n"
>> -    gdb_expect {
>> -           -re "GNU gdb .*\r\n$mi_gdb_prompt$" \
>> -               { pass "acceptance of MI operations" 
>> -                 return 1}
>> -           -re ".*\r\n$mi_gdb_prompt$" \
>> -               { fail "acceptance of MI operations"
>> -                 note "Skipping all other MI tests." }
>> -           -re "Undefined command.*$gdb_prompt $" \
>> -               { fail "acceptance of MI operations"
>> -                 note "Skipping all other MI tests." }
>> -           -re ".*$gdb_prompt $" \
>> -               { fail "acceptance of MI operations"
>> -                 note "Skipping all other MI tests." }
>> -           timeout { fail "acceptance of MI operations (timeout)"
>> -                     note "Skipping all other MI tests." }
>> +    gdb_test_multiple "-gdb-version" "acceptance of MI operations" {
> 
> You replace send_gdb with gdb_test_multiple, while changelog say you
> replace with gdb_test.
> 
>> +    note "Skipping all other MI tests."
> 
> This seem to be emitted unconditionally now? It was previously emitted
> on timeout only. There are two such issues in -- mi-basics and mi2-basics.
> Seems OK otherwise.

It's not unconditional.  The "pass" clause includes a return, so this
note will only be emitted on failure.