From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73262-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20038 invoked by alias); 24 May 2010 22:04:31 -0000
Received: (qmail 20029 invoked by uid 22791); 24 May 2010 22:04:30 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 May 2010 22:04:26 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167])	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 95ECC6002;	Mon, 24 May 2010 15:04:25 -0700 (PDT)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost2.vmware.com (Postfix) with ESMTP id 8CDAC8E7D9;	Mon, 24 May 2010 15:04:25 -0700 (PDT)
Message-ID: <4BFAF7E9.8010203@vmware.com>
Date: Mon, 24 May 2010 22:07:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.22 (X11/20090609)
MIME-Version: 1.0
To: Pedro Alves <pedro@codesourcery.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdb.base/c*.exp, send_gdb vs. gdb_test
References: <4BF84A62.40806@vmware.com> <201005222335.58505.pedro@codesourcery.com> <4BF98448.5030805@vmware.com> <201005232215.53133.pedro@codesourcery.com>
In-Reply-To: <201005232215.53133.pedro@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00555.txt.bz2

Pedro Alves wrote:
> On Sunday 23 May 2010 20:38:48, Michael Snyder wrote:
>>>> -    send_gdb "call  str_func1(s)\n"
>>>> -    gdb_expect {
>>>> -       -re "first string arg is: test string.*\"test string\".*$gdb_prompt $" {
>>>> -           pass "call str_func1(s)"
>>>> -       }
>>>> -       -re ".*$gdb_prompt $" { fail "call str_func1(s)" }
>>>> -       timeout               { fail "(timeout) call str_func1(s)" }
>>>> -    }
>>>> +    gdb_test "call  str_func1(s)" \
>>> The previous test output didn't have the extra space.  Could you
>>> remove it?  There are several instances of this.
>> What extra space are you talking about?
> 
> 'pass "call str_func1(s)"' vs 'gdb_test "call  str_func1(s)"'
>            ^                                 ^^
> 
> Your gdb_test didn't have an explicit message, so the command
> string is used as replacement.  If gdb.sum diffing didn't reveal
> this, I missed something obvious.  :-)  Anyway, just a nit.
> 

OK fixed and committed.