From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73232-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9007 invoked by alias); 21 May 2010 23:55:29 -0000
Received: (qmail 8997 invoked by uid 22791); 21 May 2010 23:55:28 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 May 2010 23:55:25 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167])	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id BEA7F13037;	Fri, 21 May 2010 16:55:23 -0700 (PDT)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost2.vmware.com (Postfix) with ESMTP id B37D38E580;	Fri, 21 May 2010 16:55:23 -0700 (PDT)
Message-ID: <4BF71D62.8090403@vmware.com>
Date: Sat, 22 May 2010 01:55:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.22 (X11/20090609)
MIME-Version: 1.0
To: Pedro Alves <pedro@codesourcery.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdb.base, f*.exp to l*.exp, send_gdb vs. gdb_test
References: <4BF6E9FC.8000503@vmware.com> <201005220001.21966.pedro@codesourcery.com>
In-Reply-To: <201005220001.21966.pedro@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00525.txt.bz2

Pedro Alves wrote:
> On Friday 21 May 2010 21:15:56, Michael Snyder wrote:
>> +    set test "unpatch child, unpatched parent breakpoints from child"
>> +    gdb_test_multiple "continue" $test {
>> +       -re "at exit.*$gdb_prompt $" {
>> +           pass "$test"
>> +       }
>> +       -re "SIGTRAP.*$gdb_prompt $" {
>> +           fail "$test"
>> +
>> +           # Explicitly kill this child, so we can continue gracefully
>> +           # with further testing...
>> +           send_gdb "kill\n"
>> +           gdb_expect {
>> +               -re ".*Kill the program being debugged.*y or n. $" {
>> +                   send_gdb "y\n"
>> +                   gdb_expect -re "$gdb_prompt $" {}
>> +               }
>> +           }
>> +       }
>> +       -re ".*$gdb_prompt $" {
>> +           fail "$test (unknown output)"
>> +       }
>> +       timeout {
>> +           fail "$test (timeout)"
>> +       }
> 
> I guess these last two cases could be deleted too?  Doesn't
> matter much --- okay anyway.

Good catch.


>> --- long_long.exp       1 Jan 2010 07:32:01 -0000       1.30
>> +++ long_long.exp       21 May 2010 20:12:01 -0000
>> @@ -61,15 +61,9 @@ if { ![runto known_types] } then { 
> ...
>> -set target_bigendian_p 1
> 
> I think you should still set this, so if the test fails,
> the following tests referencing this don't error out reading
> a non-existing variable.  Wait, the gdb_test_bi function in
> this file, the only user of this variable, isn't itself used
> anywhere.  Huh?  This means the variable could be garbage
> collected instead, and this gdb_test_multiple below simplified.

Yeah, in fact we don't need it at all.

Thanks for the review.