From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6141 invoked by alias); 21 May 2010 15:15:00 -0000 Received: (qmail 6133 invoked by uid 22791); 21 May 2010 15:15:00 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from oarmail.oarcorp.com (HELO OARmail.OARCORP.com) (67.63.146.244) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 May 2010 15:14:52 +0000 Received: from iceland.oarcorp.com (192.168.1.156) by OARmail.OARCORP.com (192.168.2.2) with Microsoft SMTP Server id 8.1.436.0; Fri, 21 May 2010 10:14:51 -0500 Message-ID: <4BF6A36A.4040308@oarcorp.com> Date: Fri, 21 May 2010 15:15:00 -0000 From: Joel Sherrill User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-2.fc12 Thunderbird/3.0.4 MIME-Version: 1.0 To: Joel Brobecker CC: Doug Evans , Tiemen Schut , "gdb-patches@sourceware.org" Subject: Re: [patch] sim/erc32/ max simulation time extended by using 64bit ints References: <4BD1BBE3020000520000FC62@pluto.sron.nl> <4BE08E95.5040500@oarcorp.com> <20100517015752.GA24402@adacore.com> <20100520231045.GL3019@adacore.com> <4BF67A0D.3020607@oarcorp.com> <20100521150529.GR3019@adacore.com> In-Reply-To: <20100521150529.GR3019@adacore.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00490.txt.bz2 On 05/21/2010 10:05 AM, Joel Brobecker wrote: >>>> * sis.h: Remove #include. >>>> (uint64, int64): Redefine without using stdint.h. >>>> (UINT64_MAX): Define. >>>> >>> FYI: I just checked that one in. >>> >>> >> Doug do you still want that VAL -> strtol/ll change? >> > Can you provide more info, which change is that? > Doug seemed to want to get rid of the "VAL" macros in the sim/erc32 source code. I handled one file in this patch because it was only used once in the file and it seemed silly to even have the macro. The other two files had more uses so I wanted to wait until the maximum time to 64 bits was committed. Here is his comment 1) -#define VAL(x) strtol(x,(char **)NULL,0) +#define VAL(x) strtoull(x,(char **)NULL,0) I realize VAL is only used once in interf.c but it's also defined in other files as well. While one could consolidate them, having the macro at all is probably less preferable to just calling strtoul{,l} directly. I would just remove it from interf.c and call strtoull directly. I have fixed this in interf.c. But didn't touch the other files. Is this OK? -- Joel Sherrill, Ph.D. Director of Research& Development joel.sherrill@OARcorp.com On-Line Applications Research Ask me about RTEMS: a free RTOS Huntsville AL 35805 Support Available (256) 722-9985