From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10421 invoked by alias); 18 May 2010 23:50:58 -0000 Received: (qmail 10413 invoked by uid 22791); 18 May 2010 23:50:58 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 May 2010 23:50:53 +0000 Received: (qmail 22438 invoked from network); 18 May 2010 23:50:51 -0000 Received: from unknown (HELO macbook-2.local) (stan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 18 May 2010 23:50:51 -0000 Message-ID: <4BF327D2.3000802@codesourcery.com> Date: Wed, 19 May 2010 14:16:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org, Jan Kratochvil Subject: Re: RFC: implement DW_OP_bit_piece References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00386.txt.bz2 Tom Tromey wrote: > I plan to check this in, but first I would appreciate comments on the > implementation. > > This patch implements DW_OP_bit_piece. This is needed now that Jakub > has pushed in gcc patches to generate it when SRA optimization is > performed. > Your code looks reasonable, but you're missing two, uh, pieces :-) - the dwarf2_tracepoint_var_ref code to compile to bytecodes, and human-readable description in locexpr_describe_location_1. (Yes it's onerous, but we did want to revive tracepoints, right?) Stan