From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11306 invoked by alias); 17 May 2010 02:08:41 -0000 Received: (qmail 11133 invoked by uid 22791); 17 May 2010 02:08:40 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from oarmail.oarcorp.com (HELO OARmail.OARCORP.com) (67.63.146.244) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 May 2010 02:08:35 +0000 Received: from localhost.localdomain (216.186.145.118) by OARmail.OARCORP.com (192.168.2.2) with Microsoft SMTP Server id 8.1.436.0; Sun, 16 May 2010 21:08:34 -0500 Message-ID: <4BF0A521.900@oarcorp.com> Date: Mon, 17 May 2010 03:23:00 -0000 From: Joel Sherrill User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4 MIME-Version: 1.0 To: Joel Brobecker CC: Doug Evans , Tiemen Schut , "gdb-patches@sourceware.org" Subject: Re: [patch] sim/erc32/ max simulation time extended by using 64bit ints References: <4BD1BBE3020000520000FC62@pluto.sron.nl> <4BE08E95.5040500@oarcorp.com> <20100517015752.GA24402@adacore.com> In-Reply-To: <20100517015752.GA24402@adacore.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00333.txt.bz2 On 05/16/2010 08:57 PM, Joel Brobecker wrote: > Hey guys, > > >> Index: sim/erc32/sis.h >> =================================================================== >> RCS file: /cvs/src/src/sim/erc32/sis.h,v >> retrieving revision 1.2 >> diff -u -r1.2 sis.h >> --- sim/erc32/sis.h 9 Jun 2002 15:45:46 -0000 1.2 >> +++ sim/erc32/sis.h 4 May 2010 21:14:55 -0000 >> @@ -23,6 +23,7 @@ >> #include "ansidecl.h" >> #include "gdb/callback.h" >> #include "gdb/remote-sim.h" >> +#include >> > Unfortunately, this change breaks the build when stdint.h is not > available (Eg. sparc-solaris). > > Apparently, this header was included for 2 things: > - define two 64bit types int64 and uint64; > - have UINT64_MAX. > > I assume that the requirement was for 64bit minimum, as opposed to > exactly 64bit? Making that assumption, we can remove the need for > including stdint.h by using long long instead of int64_t (same thing > for the unsigned counterpart). Similarly, UINT64_MAX has a well defined > value reguardless of the platform, so it can easily be defined as well. > Looking at the rest of the type definitions above, it's actually in line > with what's been done so far. > > Joel: Would that work for you as well? > Sure. I don't have a problem with that. RTEMS has all the C99 types and we are just in the habit of using them. --joel > Doug: Would that be OK to commit? I think that the cleanest thing to do > here would be to have some configury that would provide our own > stdint.h when missing. We already do that for GDB by using gnulib > so perhaps one way to do so would be to share the gnulib between > GDB and the sim (probably meaning moving it to the root directory). > > PS: We have the same problem with rx sim, I believe. I haven't tried > building it, though. > >