From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [ob] gdbarch.sh, arch-utils.c, white space
Date: Thu, 13 May 2010 22:48:00 -0000 [thread overview]
Message-ID: <4BEC77ED.4050604@vmware.com> (raw)
In-Reply-To: <4BEC75DF.80206@vmware.com>
[-- Attachment #1: Type: text/plain, Size: 95 bytes --]
Michael Snyder wrote:
> add blank line between decls and statements
Oops, here's the patch...
[-- Attachment #2: gdbarch.txt --]
[-- Type: text/plain, Size: 2869 bytes --]
2010-05-13 Michael Snyder <msnyder@vmware.com>
* gdbarch.sh: White space, add blank lines.
* arch-utils.c: Ditto.
* gdbarch.c: Regenerate.
Index: gdbarch.sh
===================================================================
RCS file: /cvs/src/src/gdb/gdbarch.sh,v
retrieving revision 1.510
diff -u -p -r1.510 gdbarch.sh
--- gdbarch.sh 7 May 2010 14:00:28 -0000 1.510
+++ gdbarch.sh 13 May 2010 21:54:31 -0000
@@ -1443,6 +1443,7 @@ void *
gdbarch_obstack_zalloc (struct gdbarch *arch, long size)
{
void *data = obstack_alloc (arch->obstack, size);
+
memset (data, 0, size);
return data;
}
@@ -1458,6 +1459,7 @@ void
gdbarch_free (struct gdbarch *arch)
{
struct obstack *obstack;
+
gdb_assert (arch != NULL);
gdb_assert (!arch->initialized_p);
obstack = arch->obstack;
@@ -1479,6 +1481,7 @@ verify_gdbarch (struct gdbarch *gdbarch)
struct cleanup *cleanups;
long length;
char *buf;
+
log = mem_fileopen ();
cleanups = make_cleanup_ui_file_delete (log);
/* fundamental */
@@ -1543,6 +1546,7 @@ void
gdbarch_dump (struct gdbarch *gdbarch, struct ui_file *file)
{
const char *gdb_nm_file = "<not-defined>";
+
#if defined (GDB_NM_FILE)
gdb_nm_file = GDB_NM_FILE;
#endif
@@ -1747,7 +1751,8 @@ gdbarch_data_register (gdbarch_data_pre_
gdbarch_data_post_init_ftype *post_init)
{
struct gdbarch_data_registration **curr;
- /* Append the new registraration. */
+
+ /* Append the new registration. */
for (curr = &gdbarch_data_registry.registrations;
(*curr) != NULL;
curr = &(*curr)->next);
@@ -1866,6 +1871,7 @@ gdbarch_printable_names (void)
int nr_arches = 0;
const char **arches = NULL;
struct gdbarch_registration *rego;
+
for (rego = gdbarch_registry;
rego != NULL;
rego = rego->next)
@@ -1894,6 +1900,7 @@ gdbarch_register (enum bfd_architecture
{
struct gdbarch_registration **curr;
const struct bfd_arch_info *bfd_arch_info;
+
/* Check that BFD recognizes this architecture */
bfd_arch_info = bfd_lookup_arch (bfd_architecture, 0);
if (bfd_arch_info == NULL)
Index: arch-utils.c
===================================================================
RCS file: /cvs/src/src/gdb/arch-utils.c,v
retrieving revision 1.188
diff -u -p -r1.188 arch-utils.c
--- arch-utils.c 6 May 2010 19:41:11 -0000 1.188
+++ arch-utils.c 13 May 2010 21:54:31 -0000
@@ -533,6 +533,7 @@ gdbarch_from_bfd (bfd *abfd)
{
struct gdbarch_info info;
gdbarch_info_init (&info);
+
info.abfd = abfd;
return gdbarch_find_by_info (info);
}
@@ -580,9 +581,9 @@ void
initialize_current_architecture (void)
{
const char **arches = gdbarch_printable_names ();
+ struct gdbarch_info info;
/* determine a default architecture and byte order. */
- struct gdbarch_info info;
gdbarch_info_init (&info);
/* Find a default architecture. */
prev parent reply other threads:[~2010-05-13 22:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 22:06 Michael Snyder
2010-05-13 22:48 ` Michael Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEC77ED.4050604@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox