Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: Stan Shebs <stan@codesourcery.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: RFC: new struct breakpoint component cond_language...
Date: Mon, 10 May 2010 23:28:00 -0000	[thread overview]
Message-ID: <4BE89677.60607@vmware.com> (raw)
In-Reply-To: <4BE895C2.6090706@codesourcery.com>

Stan Shebs wrote:
> Joel Brobecker wrote:
>> So, taking both of these elements into account, I deduce that
>> breakpoints should also store a condition_language which should be
>> used in order to parse our condition, because it can be different
>> from the breakpoint language.
>>   
> 
> Tracepoints add an extra wrinkle to this concept - when connecting to a 
> target that is currently running a trace, tracepoint conditions can be 
> uploaded from the target, and in their original source form, and so have 
> to be reparsed.  So to make this work in the multi-language case, it 
> seems like the tracepoint download should include the language somehow.
> 
> But then I wonder - when uploading a tracepoint, we receive both the 
> computed address and the source form of that address, so in theory we 
> can always deduce the correct language by working back from the 
> tracepoint address.  And if that's true, then wouldn't the language of 
> the condition be expected to be the same as the language of the 
> location?  Are tracepoints then just a special case in which the 
> condition language does not need to be recorded?

Hmmm... doesn't the breakpoint struct already record (as you mention)
the "source form" (ie. a string) of the address?  In which case, could
we not always derive the source language?

Oh, well, what if it's just a function name?  Is that enough?


  reply	other threads:[~2010-05-10 23:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-10 21:54 Joel Brobecker
2010-05-10 23:25 ` Stan Shebs
2010-05-10 23:28   ` Michael Snyder [this message]
2010-05-11  7:46   ` Joel Brobecker
2010-05-17 15:49 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE89677.60607@vmware.com \
    --to=msnyder@vmware.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=stan@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox