Tom Tromey wrote: >>>>>> "Michael" == Michael Snyder writes: > > Michael> struct value * > Michael> value_cast_pointers (struct type *type, struct value *arg2) > Michael> { > Michael> - struct type *type1 = check_typedef (type); > Michael> struct type *type2 = check_typedef (value_type (arg2)); > Michael> struct type *t1 = check_typedef (TYPE_TARGET_TYPE (type)); > Michael> struct type *t2 = check_typedef (TYPE_TARGET_TYPE (type2)); > > In this case I think the intent is for t1 to reference type1, and not type. > I would recommend making that change rather than deleting type1. OK -- committed as attached.