From: Michael Snyder <msnyder@vmware.com>
To: "tromey@redhat.com" <tromey@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] frame-unwind, gnu-v2-abi, cp-support, cp-namespace, trad-frame, tramp-frame.c: remove unused vars.
Date: Fri, 07 May 2010 18:31:00 -0000 [thread overview]
Message-ID: <4BE45C60.1060001@vmware.com> (raw)
In-Reply-To: <m3wrvffvzz.fsf@fleche.redhat.com>
Tom Tromey wrote:
> Michael> - CORE_ADDR pc = get_frame_pc (this_frame);
>
> I am not completely sure this is safe. Maybe get_frame_pc can throw an
> exception.
I thought about that, but if the function call is there
solely because of some side effect it can have, that's
pretty fishy too.
I'm willing to put it back if that's what is thought best...
prev parent reply other threads:[~2010-05-07 18:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 1:15 Michael Snyder
2010-05-07 17:43 ` Tom Tromey
2010-05-07 18:31 ` Michael Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE45C60.1060001@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox