From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22713 invoked by alias); 5 May 2010 22:37:00 -0000 Received: (qmail 22704 invoked by uid 22791); 5 May 2010 22:36:59 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 May 2010 22:36:56 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 0DB38800A; Wed, 5 May 2010 15:36:55 -0700 (PDT) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 01D4DCD91F; Wed, 5 May 2010 15:36:55 -0700 (PDT) Message-ID: <4BE1F306.8060006@vmware.com> Date: Wed, 05 May 2010 22:37:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.22 (X11/20090609) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" , Pedro Alves Subject: [RFA] remote.c, clean-up mix-up Content-Type: multipart/mixed; boundary="------------080609050902040600010701" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00136.txt.bz2 This is a multi-part message in MIME format. --------------080609050902040600010701 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 325 I'm not sure if this clean-up ever happens, because the declaration merely shadows an outer declaration of the same name, and the do_cleanups call happens outside the scope of this declaration. This is my **GUESS** as to what might be intended here. If anybody has an alternate hypothesis, it's probably better than mine. --------------080609050902040600010701 Content-Type: text/plain; name="remote2.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="remote2.txt" Content-length: 868 2010-05-05 Michael Snyder * remote.c (remote_threads_info): Remove shadowing declaration. Index: remote.c =================================================================== RCS file: /cvs/src/src/gdb/remote.c,v retrieving revision 1.407 diff -u -p -5 -r1.407 remote.c --- remote.c 5 May 2010 22:27:15 -0000 1.407 +++ remote.c 5 May 2010 22:31:28 -0000 @@ -2510,12 +2510,12 @@ remote_threads_info (struct target_ops * struct cleanup *back_to = make_cleanup (xfree, xml); if (xml && *xml) { struct gdb_xml_parser *parser; struct threads_parsing_context context; - struct cleanup back_to = make_cleanup (null_cleanup, NULL); + back_to = make_cleanup (null_cleanup, NULL); context.items = 0; parser = gdb_xml_create_parser_and_cleanup (_("threads"), threads_elements, &context); --------------080609050902040600010701--