From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30155 invoked by alias); 5 May 2010 21:14:26 -0000 Received: (qmail 30146 invoked by uid 22791); 5 May 2010 21:14:25 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 May 2010 21:14:19 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id A92D436014; Wed, 5 May 2010 14:14:17 -0700 (PDT) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id A2E97C9C6A; Wed, 5 May 2010 14:14:17 -0700 (PDT) Message-ID: <4BE1DFA9.9060607@vmware.com> Date: Wed, 05 May 2010 21:14:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.22 (X11/20090609) MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [ob] remote.c, eliminate unused variables References: <4BE1D93F.8000309@vmware.com> <201005052151.19745.pedro@codesourcery.com> In-Reply-To: <201005052151.19745.pedro@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00127.txt.bz2 Pedro Alves wrote: > On Wednesday 05 May 2010 21:46:55, Michael Snyder wrote: >> 2010-05-05 Michael Snyder >> >> * remote.c (remote_threads_info): Delete unused variable. >> (process_stop_reply): Delete unused variable. >> (remote_get_trace_status): Delete unused variables. >> >> Index: remote.c >> =================================================================== >> RCS file: /cvs/src/src/gdb/remote.c,v >> retrieving revision 1.405 >> diff -u -p -r1.405 remote.c >> --- remote.c 5 May 2010 15:05:57 -0000 1.405 >> +++ remote.c 5 May 2010 20:43:46 -0000 >> @@ -2512,8 +2512,8 @@ remote_threads_info (struct target_ops * >> { >> struct gdb_xml_parser *parser; >> struct threads_parsing_context context; >> - struct cleanup *back_to = make_cleanup (null_cleanup, NULL); >> >> + make_cleanup (null_cleanup, NULL); > > Are you making sure (in all your patches) that the reason the > variables are unused isn't itself a bug? Can't guarantee it, no. I'm making sure the semantics isn't changed, but I can't always be sure that the original semantics was right. > In this case, creating a > null_cleanup and not storing a pointer anywhere is > highly suspicious... Well, then it was wrong when I got there. The variable that it was stored to was not used, but shadowed an outer scope variable of the same name, which was used. Maybe it should have stored it without declaring it? I don't know... what do you think?