From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15016 invoked by alias); 27 Apr 2010 19:25:05 -0000 Received: (qmail 14979 invoked by uid 22791); 27 Apr 2010 19:25:04 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Apr 2010 19:24:59 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3RJOvcD007595 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 Apr 2010 15:24:57 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3RJOuvG016631; Tue, 27 Apr 2010 15:24:56 -0400 Message-ID: <4BD73A07.7020706@redhat.com> Date: Tue, 27 Apr 2010 19:25:00 -0000 From: Phil Muldoon User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: [python][patch] Add GDB Parameters functionality References: <4BD592D9.1070801@redhat.com> <838w8ayu7a.fsf@gnu.org> <4BD6D7C7.9040804@redhat.com> <83wrvsyelz.fsf@gnu.org> In-Reply-To: <83wrvsyelz.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00919.txt.bz2 On 04/27/2010 06:44 PM, Eli Zaretskii wrote: >> +@item PARAM_STRING >> +The value is a string. When the user modifies the string, any escapes >> +sequences are translated and encoded by @value{GDBN}. > > I asked to say something about this translation, or provide an > example. I'm just not sure what to say other than GDB will translate and encode any escape sequences in the string. In fact, 'encoded' will probably just do here without the 'translated' verb - it seems redundant with the new encoded text. I think that is clearer. How about that with a cross-reference to encoding (pxref{Character Sets})? >> +@item PARAM_FILENAME >> +The value is a filename (a string). This value is has to be a valid >> +filename. ^^ > > The "is" part is probably redundant. Also, what does it mean "a valid > filename"? Does it have to exist, for example? If not, what makes a > file name "invalid"? I looked a little deeper at this. There is no validation (I was initially wrong, apologies). Furthermore, it does not have to be a valid filename at all -- just a string. Validation is presumably offloaded to the Parameter to check. Anyway, it is a simple string. The classification of Parameter type in these cases is purely to do with how completion works -- if the user chooses to use completion. So 'set foo somefil' will complete looking for filenames: Eg: (gdb) set logging file ~/log log.txt log2.txt Whereas for a Parameter with the type PARAM_BOOLEAN (like set verbose) it would complete like so: (gdb) set verbose o off on Now that being said, I'm a little stumped how to explain all of this within the context of these parameter types. Do you have any input here? Cheers Phil