From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28987 invoked by alias); 22 Apr 2010 20:13:06 -0000 Received: (qmail 28973 invoked by uid 22791); 22 Apr 2010 20:13:04 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Apr 2010 20:12:58 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3MKCuWh015187 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 22 Apr 2010 16:12:56 -0400 Received: from qcore.mollernet.net (vpn-10-25.rdu.redhat.com [10.11.10.25]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3MKCu3a029031; Thu, 22 Apr 2010 16:12:56 -0400 Message-ID: <4BD0ADC8.3010303@redhat.com> Date: Thu, 22 Apr 2010 20:13:00 -0000 From: Chris Moller User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: tromey@redhat.com CC: "gdb-patches@sourceware.org" Subject: Re: Another obstack patch. References: <4BD057DF.7070904@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00764.txt.bz2 On 04/22/10 15:03, Tom Tromey wrote: >>>>>> "Chris" == Chris Moller writes: >>>>>> > > Chris> static void cp_print_value (struct type *, struct type *, const gdb_byte *, > Chris> int, CORE_ADDR, struct ui_file *, int, > Chris> - const struct value_print_options *, struct type **); > Chris> + const struct value_print_options *, > Chris> + struct type **); > > Don't mix reformatting and semantic changes. > > Chris> + if (obstack_final_size> stat_array_obstack_initial_size) { > > Wrong brace placement. > > Ok with those changes. > Fixed and committed. cm > Tom >