From: Chris Moller <cmoller@redhat.com>
To: tromey@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: PR9167 Derived class static member CRTP infinite recursion on print
Date: Wed, 21 Apr 2010 17:35:00 -0000 [thread overview]
Message-ID: <4BCF3752.20103@redhat.com> (raw)
In-Reply-To: <m3y6giezcs.fsf@fleche.redhat.com>
Fixed up and committed.
On 04/20/10 14:46, Tom Tromey wrote:
>>>>>> "Chris" == Chris Moller<cmoller@redhat.com> writes:
>>>>>>
>
> Chris> You can't do that. obstack_base() returns a pointer to the current
> Chris> allocation, which may change depending on what's stuffed into the
> Chris> obstack--by the time the obstack_free is hit, the base may have
> Chris> changed.
>
> Why do we need to pop the stack at all?
> It seems to me that if we printed something once, during a given call
> into val_print, then we should never try to print it again.
> Am I missing something?
>
> Chris> + void * free_to_ptr =
>
> No space after the "*".
>
> Chris> obstack_grow (&dont_print_statmem_obstack, (char *)&addr,
> Chris> sizeof (CORE_ADDR));
> Chris> -
> Chris> CHECK_TYPEDEF (type);
>
> Gratuitious whitespace change.
>
> This is ok with those changes. Thanks.
>
> Tom
>
next prev parent reply other threads:[~2010-04-21 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 3:48 Chris Moller
2010-04-20 19:00 ` Tom Tromey
2010-04-21 17:35 ` Chris Moller [this message]
2010-04-21 18:48 ` Chris Moller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCF3752.20103@redhat.com \
--to=cmoller@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox