Re: [PATCH] Do partial xfers from trace file

Mike Frysinger
2010-04-13T03:05:35Z

[-- Attachment #1: Type: Text/Plain, Size: 1172 bytes --]

On Monday 05 April 2010 18:10:49 Stan Shebs wrote:
> Memory blocks in the trace buffer are limited to 65K (to save a couple
> bytes in the length field, since most blocks are small), and a tester
> trying to collect a quarter-megabyte(!) C++ object ran into trouble with
> that. The fix is really a target-side thing, but the trace file reader
> needs to cognizant of this detail also. Fortunately, we can exploit
> GDB's partial xfer mechanism, and just return what we find in one block,
> expecting that GDB will re-request the remainder.
>
> I also made the tfile target has_all_memory, and added an emulation of
> QTro behavior, which lets disassembly and the like work, but rejects
> attempts to print non-constant globals that were not collected.
> Committed to trunk.

there's some problems with this commit ...

it introduces a warning which breaks with -Werror:
tracepoint.c: In function ‘tfile_xfer_partial’:
tracepoint.c:3895: error: ignoring return value of ‘read’, declared with
attribute warn_unused_result

that particular piece of code also has slightly broken whitespace:
<space><space><tab><space><space>.......
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]