From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71907-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24228 invoked by alias); 9 Apr 2010 10:11:00 -0000
Received: (qmail 24219 invoked by uid 22791); 9 Apr 2010 10:10:59 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 10:10:54 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o39AAT05002118 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Fri, 9 Apr 2010 06:10:30 -0400
Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o39AARl7008064; 	Fri, 9 Apr 2010 06:10:28 -0400
Message-ID: <4BBEFD13.7090605@redhat.com>
Date: Fri, 09 Apr 2010 10:11:00 -0000
From: Phil Muldoon <pmuldoon@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.3
MIME-Version: 1.0
To: Tom Tromey <tromey@redhat.com>
CC: Joel Brobecker <brobecker@adacore.com>,         gdb-patches ml <gdb-patches@sourceware.org>,         Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch][python] Add breakpoint support.
References: <4BB0B063.6000600@redhat.com> <20100405162648.GD19194@adacore.com> 	<4BBB3AF6.8050407@redhat.com> <m3ochvt1fr.fsf@fleche.redhat.com> 	<4BBDCF0E.9020904@redhat.com> <m3zl1dpvkg.fsf@fleche.redhat.com>
In-Reply-To: <m3zl1dpvkg.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00226.txt.bz2

On 04/08/2010 08:56 PM, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
> 
>> Phil> I've replaced the BPPY_VALID_P macro with a static function in this
>> Phil> patch.  I also updated the s/ask/task typo.  What do you think?

> Tom> Looks ok to me.

> Joel> Seems good to commit to me. 

> Eli> Thanks.  The documentation part is okay.


So committed, thanks.

Cheers,

Phil