From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1146 invoked by alias); 9 Apr 2010 00:55:20 -0000 Received: (qmail 1136 invoked by uid 22791); 9 Apr 2010 00:55:19 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 00:55:15 +0000 Received: (qmail 20874 invoked from network); 9 Apr 2010 00:55:13 -0000 Received: from unknown (HELO macbook-2.local) (stan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Apr 2010 00:55:13 -0000 Message-ID: <4BBE7AEB.4090004@codesourcery.com> Date: Fri, 09 Apr 2010 00:55:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) MIME-Version: 1.0 To: Stan Shebs CC: gdb-patches@sourceware.org Subject: Re: [PATCH/RFC] Include value of default-collect in breakpoint/tracepoint list References: <4BBA7264.5060109@codesourcery.com> In-Reply-To: <4BBA7264.5060109@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00215.txt.bz2 I cleverly managed to regression-test the wrong tree - leftover default-collect settings can affect info output, so this patch cleans up after testing. Committed to trunk. Stan 2010-04-08 Stan Shebs * gdb.trace/actions.exp: Clear default-collect. * gdb.trace/save-trace.exp: Clear default-collect. Index: gdb.trace/actions.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.trace/actions.exp,v retrieving revision 1.17 diff -p -r1.17 actions.exp *** gdb.trace/actions.exp 1 Apr 2010 22:57:25 -0000 1.17 --- gdb.trace/actions.exp 9 Apr 2010 00:49:20 -0000 *************** gdb_test "show default-collect" \ *** 204,209 **** --- 204,213 ---- "The list of expressions to collect by default is \"gdb_char_test, gdb_long_test - 100\"..*" \ "5.9b: show default-collect" + gdb_test "set default-collect" \ + "" \ + "5.9c: set default-collect" + # 5.10 teval gdb_test "tvariable \$tsv" \ Index: gdb.trace/save-trace.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.trace/save-trace.exp,v retrieving revision 1.15 diff -p -r1.15 save-trace.exp *** gdb.trace/save-trace.exp 31 Mar 2010 17:59:49 -0000 1.15 --- gdb.trace/save-trace.exp 9 Apr 2010 00:49:20 -0000 *************** gdb_test "save-tracepoints savetrace.tr" *** 135,140 **** --- 135,141 ---- # 10.2 Read back tracepoint definitions gdb_delete_tracepoints + gdb_test "set default-collect" "" "10.2: clear default-collect" gdb_test "info tracepoints" "No tracepoints." "10.2: delete tracepoints" gdb_test "source savetrace.tr" \ "Tracepoint \[0-9\]+ at .*" \ *************** gdb_test "save-tracepoints $objdir/savet *** 151,156 **** --- 152,158 ---- "10.3: save tracepoint definitions, full path" gdb_delete_tracepoints + gdb_test "set default-collect" "" "10.3: clear default-collect" gdb_test "info tracepoints" "No tracepoints." "10.3: delete tracepoints" gdb_test "source $objdir/savetrace.tr" \ "Tracepoint \[0-9\]+ at .*" \