From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13665 invoked by alias); 5 Apr 2010 23:30:00 -0000 Received: (qmail 13633 invoked by uid 22791); 5 Apr 2010 23:29:52 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Apr 2010 23:29:47 +0000 Received: (qmail 17292 invoked from network); 5 Apr 2010 23:29:46 -0000 Received: from unknown (HELO macbook-2.local) (stan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Apr 2010 23:29:46 -0000 Message-ID: <4BBA7264.5060109@codesourcery.com> Date: Mon, 05 Apr 2010 23:30:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: [PATCH/RFC] Include value of default-collect in breakpoint/tracepoint list Content-Type: multipart/mixed; boundary="------------000002050107070804050102" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00087.txt.bz2 This is a multi-part message in MIME format. --------------000002050107070804050102 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 792 Although it's always possible to find out the value of default-collect by doing a show command, in practice it's convenient to see it listed as part of "info break" or "info trace"; it helps keep the user aware that more may be getting collected than is listed with individual tracepoints. This patch just gives it a line after the listing, and doesn't say anything if it is empty. Since this is not strictly necessary and maybe even a little irregular, I invite comments - if enough people put finger down throat and make gagging noises, I'll withdraw it. :-) Stan 2010-04-05 Stan Shebs * breakpoint.c (default_collect_info): New function. (breakpoints_info): Call it. (maintenance_info_breakpoints): Ditto. (tracepoints_info): Ditto. --------------000002050107070804050102 Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0"; name="dcinfo-patch-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="dcinfo-patch-1" Content-length: 1991 Index: breakpoint.c =================================================================== RCS file: /cvs/src/src/gdb/breakpoint.c,v retrieving revision 1.478 diff -p -r1.478 breakpoint.c *** breakpoint.c 5 Apr 2010 10:07:30 -0000 1.478 --- breakpoint.c 5 Apr 2010 23:17:37 -0000 *************** breakpoint_commands (struct breakpoint * *** 241,246 **** --- 241,248 ---- return b->commands ? b->commands->commands : NULL; } + static void default_collect_info (void); + /* Flag indicating that a command has proceeded the inferior past the current breakpoint. */ *************** breakpoints_info (char *bnum_exp, int fr *** 5061,5066 **** --- 5063,5070 ---- bnum = parse_and_eval_long (bnum_exp); breakpoint_1 (bnum, 0, NULL); + + default_collect_info (); } static void *************** maintenance_info_breakpoints (char *bnum *** 5091,5096 **** --- 5095,5102 ---- bnum = parse_and_eval_long (bnum_exp); breakpoint_1 (bnum, 1, NULL); + + default_collect_info (); } static int *************** tracepoints_info (char *tpnum_exp, int f *** 10463,10470 **** --- 10469,10497 ---- else ui_out_message (uiout, 0, "No tracepoint number %d.\n", tpnum); } + + default_collect_info (); } + /* Display the value of default-collect in a way that is generally + compatible with the breakpoint list. */ + + void + default_collect_info (void) + { + /* If it has no value (which is frequently the case), say nothing; a + message like "No default-collect." gets in user's face when it's + not wanted. */ + if (!*default_collect) + return; + + /* The following phrase lines up nicely with per-tracepoint collect + actions. */ + ui_out_text (uiout, "default collect "); + ui_out_field_string (uiout, "default-collect", default_collect); + ui_out_text (uiout, " \n"); + } + /* The 'enable trace' command enables tracepoints. Not supported by all targets. */ static void --------------000002050107070804050102--